Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maybe_ for cmp, partial_cmp, eq, ne, lt, le, gt, ge #952

Closed
Xenira opened this issue May 28, 2024 · 2 comments
Closed

maybe_ for cmp, partial_cmp, eq, ne, lt, le, gt, ge #952

Xenira opened this issue May 28, 2024 · 2 comments

Comments

@Xenira
Copy link
Contributor

Xenira commented May 28, 2024

Grouped this together, as those methods all take a second iterator (or IntoIterator to be precise) with Ord item as argument.

Having results would require something like this (if that even works, did not test yet):

iter.process_results(
     |iter| other.process_results(|other| iter.ge(other))
)??,

Having maybe_ methods would make this way less verbose and the intent clearer.

Related to #844 and label GitHub labels

@Philippe-Cholet
Copy link
Member

Philippe-Cholet commented May 28, 2024

I personally don't know where those cmp & Co. methods are used. I never did myself (but I'm no veteran). So I don't know if there is a need for 8 maybe_ methods, especially when no one asked (AFAIK) for cmp_ok or related (we have a few _ok methods).

@Xenira
Copy link
Contributor Author

Xenira commented May 29, 2024

Don't have a concrete usecase as well. Kind wanted to support it as a lib function. Can be closed until someone has a real usecase.

@Xenira Xenira closed this as completed May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants