Spring Metrics doesn't support Spring Expression Lanuage

[404pilot]

Just added port="#{appProperties['graphite.port']}" in applicationContext-metrics.xml. However, the metrics-spring will first validate port field and then throw an exception about failure validation. I checked the code in line 220 of AbstractReporterElementParser, it turns out the SpEL is not supported, since "^\\$\\{.*\\}$" is just a placeholder regex. It could be nice if SpEl is supported.

[ryantenney]

I don't see any reason why this shouldn't work. I'll give it a shot and get back to you.

[404pilot]

@ryantenney SpEl starts with # which doesn't match regex ^\\$\\{.*\\}$

[ryantenney]

Yea, I understood that part of it. What I meant was I don't see any reason why it wouldn't be possible to enable SpEL. Sorry for the misunderstanding.

[404pilot]

@ryantenney Sorry I am not sure I understood your question:) During the initialization of application, metrics-spring will first validate the port number by using regex pattern ^\\$\\{.*\\}$ and find out SpEl doesn't match. At this point, SpEl haven't been translated into actual value.

[netwein]

I think SpEl should be also be implemented for metric's name

[ryantenney]

I attempted to fix this by changing the regex to [$#]\{.*\}, but Spring still doesn't resolve the SpEL. I'll keep working on it.

[ryantenney]

SpEL has proven to be exceptionally difficult to support. I don't forsee being able to support this at any point in the near future. If anyone can help with this issue I would welcome the assistance.

[yangtao309]

this problem can be fix it ？