Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imgur link parser error. #89

Closed
wliu6v opened this issue Feb 6, 2018 · 2 comments
Closed

imgur link parser error. #89

wliu6v opened this issue Feb 6, 2018 · 2 comments

Comments

@wliu6v
Copy link

wliu6v commented Feb 6, 2018

There's two different imgur link:

But they are resolved into the same card.

image

These imgur id are different:

image

@JoshyPHP
Copy link
Member

JoshyPHP commented Feb 6, 2018

Yes, links with an ID shorter than 6 characters are interpreted as gallery links because of some backward compatibility issue.

I'm not sure I can change that behaviour so currently, the only workaround is to link to the image directly, e.g. https://i.imgur.com/j54iW.jpg

I'm going to close this issue for now because the issue is with the hosted iframe and not the library but I will revisit later.

@wliu6v
Copy link
Author

wliu6v commented Feb 6, 2018

I'm working on amp, and using <amp-imgur> to implement imgur card.
For amp-imgur, these two imgur are correct with different imgur id : j54iW and a/j54iW.

image

--

image

--

I‘m not sure if you can fix this issue in a similar way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants