Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors when used on galleries with mixed content #8

Open
vwong opened this issue Apr 20, 2021 · 0 comments
Open

Errors when used on galleries with mixed content #8

vwong opened this issue Apr 20, 2021 · 0 comments

Comments

@vwong
Copy link

vwong commented Apr 20, 2021

On galleries with mixed image and video content, this plugin raises exceptions when the current slide is not an image.

The error appears to originate from

var image = _this.core.outer.querySelector('.lg-current .lg-image');

Where the query selector fails, var image is undefined, raising errors when trying to read image.clientWidth and image.clientHeight. Should there be a guard against non-image slides?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant