Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bad vinepair scrapes #4

Open
samayer12 opened this issue Dec 28, 2021 · 2 comments
Open

Fix bad vinepair scrapes #4

samayer12 opened this issue Dec 28, 2021 · 2 comments

Comments

@samayer12
Copy link
Owner

Several files within recipes/vinepair are borked and throw exceptions when we try to read them. The attached log file contains the specifics. Short term fix is to go in and make them work by hand. Longer term fix is to repair src/scrapers/vinepair.py

Here's the error file: vinepair_errors.log

@blaverick62
Copy link
Collaborator

Seems like the issue is that yaml-special characters like ':' are bring brought into the ingredients.

@blaverick62
Copy link
Collaborator

Fixed vinepair.py to remove bad characters during scrape. Added fixed recipes. Still remaining scrape quality issues, but all parse into correct yaml as of commit 34d1cb6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants