Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin fails to build (4.x, windows) #21

Open
MatteoPiovanelli opened this issue May 8, 2024 · 1 comment
Open

Plugin fails to build (4.x, windows) #21

MatteoPiovanelli opened this issue May 8, 2024 · 1 comment

Comments

@MatteoPiovanelli
Copy link

I'm building the plugin on my Windows machine.

My compilation Pipeline uses VIsual Studio 2022 (rather, its build tools) and scons 4.7.

I have several errors where private members of Bullet are being referenced.

Many of those instances can be "fixed" by making those members as protected rather than private. In some cases I'm having to invoke the corresponding getters/setter. (I've actually added a method to increase the value of lifetime directly.

Does that make sense? I'll draft a PR once I'm done and I have something that builds and looks to perhaps work right.

@samdze
Copy link
Owner

samdze commented May 8, 2024

Yes it is an issue that has been reported before but was fixed by the same user by changing its toolchain on Windows.
Sure, you can draft a PR against the 4.x branch with the access specifiers changes if you want

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants