Skip to content

Commit 731ee8c

Browse files
authoredSep 17, 2024
SAK-46579 Rubrics cannot unselect ratings in graded rubric (sakaiproject#12893)
1 parent 0892f15 commit 731ee8c

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed
 

‎webcomponents/tool/src/main/frontend/packages/sakai-rubrics/src/SakaiRubricGrading.js

+5-4
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,9 @@ export class SakaiRubricGrading extends rubricsApiMixin(RubricsElement) {
123123
<div class="sak-banner-warn">
124124
${this.tr("draft_evaluation", [ this.tr(`draft_evaluation_${this.toolId}`) ])}
125125
</div>
126-
` : nothing }
126+
` : html`
127+
<div class="mb-3"></div>
128+
`}
127129
<div class="criterion grading style-scope sakai-rubric-criteria-grading">
128130
${this._criteria.map(c => html`
129131
<div id="criterion_row_${c.id}" class="criterion-row">
@@ -432,7 +434,6 @@ export class SakaiRubricGrading extends rubricsApiMixin(RubricsElement) {
432434
criterion.selectedRatingId = 0;
433435
criterion.pointoverride = 0.0;
434436
criterion.ratings.forEach(r => r.selected = false);
435-
criterion.comments = undefined;
436437
}
437438

438439
toggleRating(e) {
@@ -448,12 +449,12 @@ export class SakaiRubricGrading extends rubricsApiMixin(RubricsElement) {
448449
const criterion = this._criteria.filter(c => c.id == criterionId)[0];
449450
const rating = criterion.ratings.filter(r => r.id === ratingId)[0];
450451

451-
criterion.ratings.forEach(r => r.selected = false);
452-
453452
if (rating.selected) {
454453
this.emptyCriterion(criterion);
455454
rating.selected = false;
455+
e.currentTarget.blur();
456456
} else {
457+
criterion.ratings.forEach(r => r.selected = false);
457458
const auxPoints = this._rubric.weighted ?
458459
(rating.points * (criterion.weight / 100)).toFixed(2) : rating.points;
459460
criterion.selectedvalue = auxPoints;

0 commit comments

Comments
 (0)
Please sign in to comment.