-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to define settings #5
Comments
Thanks, glad you like it. my 2c: Your second ask—can you clarify, you mean you want a click on one element to trigger a ripple on another? (I can see cases where e.g., the inner thing has layout but you want an outer thing to ripple). |
Okay, cool <div class="outer rippleJS">
<span>text</span>
</div> If I click the |
@atomiks I don't think this is an issue. The following should give you your desired effect. <div class="outer">
<span>text</span>
<div class="rippleJS"></div>
</div> |
@atomiks For your first issue on params, I have a fork which adds 2 attributes for color and duration. I also added additional ways to identify elements that should ripple that is less confusing and verbose <div class="bar square" ripplejs ripplejs-color="blue" ripplejs-duration="2000ms" ripplejs-fill>
My Content
</div>
<div class="bar square">
<span>Clickable</span>
<div class="rippleJS" data-ripplejs-color="red" data-ripplejs-duration="1s" data-ripplejs-fill></div>
</div> |
Firstly, nice little library!
I'd like to define my own settings to modify the ripple. If you don't want users to use a constructor/call a factory, then perhaps use
data-*
attributes on the element you specify therippleJS
class name.The main settings I'd like is
mousedown
event but still want to trigger the ripple on the parent, so the ripple won't work.The text was updated successfully, but these errors were encountered: