You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
See the comment on SecondaryOrSupplementarySkippingIterator - it combines a peekable iterator with an implicit filter, but it would be cleaner if these were implemented separately and then composed.
Should we get rid of, or rename, NotPrimarySkippingIterator (currently unused)? The problem is that it only filters out secondary (but not supplementary) alignments, but someone new to the code might well assume that "not primary" means neither secondary not supplementary.
Where possible, we should make Iterators also implement Iterable so that for-each syntax can be used.
The text was updated successfully, but these errors were encountered:
That's a crazily specific class to begin with. Definitely agree that it should be a composite of filtering iterator wrapped around a peeking iterator or something like that.
This is something that doesn't seem to correct match any existing
tool out there with regard to the full gamut of corner cases, but in
that regard it has no favourites!
Fixessamtools#177
The text was updated successfully, but these errors were encountered: