Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Iterators / Iterables #177

Open
mattsooknah opened this issue Feb 23, 2015 · 2 comments
Open

Clean up Iterators / Iterables #177

mattsooknah opened this issue Feb 23, 2015 · 2 comments

Comments

@mattsooknah
Copy link
Member

  1. See the comment on SecondaryOrSupplementarySkippingIterator - it combines a peekable iterator with an implicit filter, but it would be cleaner if these were implemented separately and then composed.
  2. Should we get rid of, or rename, NotPrimarySkippingIterator (currently unused)? The problem is that it only filters out secondary (but not supplementary) alignments, but someone new to the code might well assume that "not primary" means neither secondary not supplementary.
  3. Where possible, we should make Iterators also implement Iterable so that for-each syntax can be used.
@lbergelson
Copy link
Member

That's a crazily specific class to begin with. Definitely agree that it should be a composite of filtering iterator wrapped around a peeking iterator or something like that.

@nh13
Copy link
Member

nh13 commented Feb 23, 2015

For (2) the intention is that it is either primary or secondary (see the Multi-mapping section in the SAM spec). Supplementary is something different.

@nh13 nh13 added the dev label Mar 6, 2015
yfarjoun pushed a commit to yfarjoun/htsjdk that referenced this issue Jun 5, 2019
This is something that doesn't seem to correct match any existing
tool out there with regard to the full gamut of corner cases, but in
that regard it has no favourites!

Fixes samtools#177
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants