Skip to content
This repository has been archived by the owner on Jul 21, 2021. It is now read-only.

FLWSrvr should return error, not bool #115

Open
langston-barrett opened this issue Apr 13, 2016 · 0 comments
Open

FLWSrvr should return error, not bool #115

langston-barrett opened this issue Apr 13, 2016 · 0 comments

Comments

@langston-barrett
Copy link

The description states:

If the boolean value is false there was a problem. If the *ServerStats slice is empty or nil, then the error happened before we started to obtain 'srvr' values. Otherwise, one of the servers had an issue and the "Error" value in the struct should be inspected to determine which server had the issue.

The golang convention is to use some kind of error type, not a bool. This should especially happen when the there are no srvr values to extract an error from.

Maybe a custom error type that holds a slice of affected servers?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant