EventNodeDeleted is missing

[Vanderpool]

According to zookeeper document, if ChildrenWatcher is set on a node, when this node deleted, EventNodeDeleted should be received on the watcher. But this event is only sent to Conn.eventChan.

example code:

package main

import (
        "fmt"
        "github.com/samuel/go-zookeeper/zk"
        "time"
)

func main() {
        c, zkChan, err := zk.Connect([]string{"127.0.0.1"}, time.Second) //*10)
        if err != nil {
                panic(err)
        }
        children, stat, wCh, err := c.ChildrenW("/foo")
        if err != nil {
                panic(err)
        }
        fmt.Printf("%+v %+v\n", children, stat)
        for {
                select {
                case e := <-wCh:
                        fmt.Printf("get event from watcher: %+v\n", e)
                case e := <-zkChan:
                        fmt.Printf("get event from session: %+v\n", e)
                }
        }
}

output:

go run watcher.go 
[] &{Czxid:25769803778 Mzxid:25769803778 Ctime:1394091427992 Mtime:1394091427992 Version:0 Cversion:0 Aversion:0 EphemeralOwner:0 DataLength:2 NumChildren:0 Pzxid:25769803778}
get event from session: {Type:EventSession State:StateConnecting Path: Err:<nil>}
get event from session: {Type:EventSession State:StateConnected Path: Err:<nil>}
get event from session: {Type:EventSession State:StateHasSession Path: Err:<nil>}
get event from session: {Type:EventNodeDeleted State:StateSyncConnected Path:/foo Err:<nil>}
^Cexit status 2

seems a minor modification is needed on conn.go:

@@ -497,7 +497,7 @@ func (c *Conn) recvLoop(conn net.Conn) error {
            case EventNodeCreated:
                wTypes = append(wTypes, watchTypeExist)
            case EventNodeDeleted, EventNodeDataChanged:
 -              wTypes = append(wTypes, watchTypeExist, watchTypeData)
 +              wTypes = append(wTypes, watchTypeExist, watchTypeData, watchTypeChild)
            case EventNodeChildrenChanged:
                wTypes = append(wTypes, watchTypeChild)
            }

[samuel]

Thanks for the report. Fixed in master: 8edc763