Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any-Version on npm #4

Closed
ShimShamSam opened this issue Sep 6, 2016 · 7 comments
Closed

Any-Version on npm #4

ShimShamSam opened this issue Sep 6, 2016 · 7 comments

Comments

@ShimShamSam
Copy link

Is it possible to install the any-version as a dependency? Is it on NPM?

@sapics
Copy link
Owner

sapics commented Sep 6, 2016

Yes it is possible by writing

"html-minifier-loader": "https://github.com/sapics/html-minifier-loader.git#any-version"

in package.json. No npm, now.

@ShimShamSam
Copy link
Author

Is there a reason it's in a separate branch? Many of the standard loaders for Webpack use the peerDependency pattern. Why lock this particular loader into a specific version?

@sapics
Copy link
Owner

sapics commented Sep 7, 2016

Many of the standard loaders for Webpack use the peerDependency pattern.

I did not know that. Thanks! I will search them.

Is there a reason it's in a separate branch?

I am afraid that current user need to fix thier package.json, isn't it?
And, I guess that peerDependency is not necessary in npm3 which is default npm in nodejs 6, isn't it?

@sapics
Copy link
Owner

sapics commented Sep 7, 2016

I am afraid that current user need to fix thier package.json, isn't it?

I confirmed that it is not necessary by testing.
Thus I will fix. Thanks for your suggestion!

@sapics
Copy link
Owner

sapics commented Sep 7, 2016

@ShimShamSam
I fixed and published to npm. I fix README as

- npm install html-minifier-loader html-minifier
+ npm install html-minifier-loader

@ShimShamSam
Copy link
Author

As long as you bump the major version number, people still using the old version won't have an issue.

@sapics
Copy link
Owner

sapics commented Sep 7, 2016

@ShimShamSam
As written in #5, it looks better to using previous version (which is not include peerDependencies) in npm 3.
Do you have any better ideas?

@sapics sapics closed this as completed Oct 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants