return in finally: overrides return in except:

[iritkatriel]

In

bitstring/bitstring/array_.py

Line 768 in c77c727

return self._apply_op_between_arrays(op, other, is_comparison=True)

the return in finally: will override the return NotImplemented in the except: clause, so I don't think this code does what it was intended to do.

>>> def f():
...     try:
...         1/0
...     except:
...         return 1
...     finally:
...         return 2
...         
>>> f()
2

See also https://docs.python.org/3/tutorial/errors.html#defining-clean-up-actions.

[scott-griffiths]

Hmm, yes good point. I think this ended up like that after a bit of a refactor so it's not that clear what it's even supposed to do! It appears harmless but I'll fix it in the next release. Thanks.