Skip to content

Commit c4d3638

Browse files
committed
Remove the OS X checks from travis.sh, instead use excludes to not fire up a vm for something we can't test.
1 parent 9cbdaed commit c4d3638

File tree

2 files changed

+31
-7
lines changed

2 files changed

+31
-7
lines changed

.travis.yml

+23-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,8 @@
11
sudo: required
2+
# Note: travis currently does not support listing more than one language so
3+
# this cheats and claims to only be cpp. If they add multiple language
4+
# support, this should probably get updated to install steps and/or
5+
# rvm/gemfile/jdk/etc. entries rather than manually doing the work.
26
language: cpp
37
os:
48
- linux
@@ -23,9 +27,27 @@ env:
2327
- CONFIG=ruby22
2428
- CONFIG=jruby
2529
matrix:
26-
allow_failures:
30+
exclude:
31+
# It's nontrivial to programmatically install a new JDK from the command
32+
# line on OS X, so we rely on testing on Linux for Java code.
33+
- os: osx
34+
env: CONFIG=java_jdk6
35+
- os: osx
36+
env: CONFIG=java_jdk7
37+
- os: osx
38+
env: CONFIG=java_oracle7
39+
- os: osx
40+
env: CONFIG=javanano_jdk6
41+
- os: osx
42+
env: CONFIG=javanano_jdk7
43+
- os: osx
44+
env: CONFIG=javanano_oracle7
45+
# Requires installing mono, currently travis.sh is doing that with apt-get
46+
# which doesn't work on OS X.
2747
- os: osx
2848
env: CONFIG=csharp
49+
allow_failures:
50+
# These currently do not work on OS X but are being worked on by @haberman.
2951
- os: osx
3052
env: CONFIG=ruby22
3153
- os: osx

travis.sh

+8-6
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,13 @@
11
#!/usr/bin/env bash
22

3+
# Note: travis currently does not support testing more than one language so the
4+
# .travis.yml cheats and claims to only be cpp. If they add multiple language
5+
# support, this should probably get updated to install steps and/or
6+
# rvm/gemfile/jdk/etc. entries rather than manually doing the work.
7+
8+
# .travis.yml uses matrix.exclude to block the cases where app-get can't be
9+
# use to install things.
10+
311
build_cpp() {
412
./autogen.sh
513
./configure
@@ -28,12 +36,6 @@ build_csharp() {
2836
}
2937

3038
use_java() {
31-
if [ `uname` != "Linux" ]; then
32-
# It's nontrivial to programmatically install a new JDK from the command
33-
# line on OS X, so we rely on testing on Linux for Java code.
34-
echo "Java not tested on OS X."
35-
exit 0 # success
36-
fi
3739
version=$1
3840
case "$version" in
3941
jdk6)

0 commit comments

Comments
 (0)