Skip to content

Commit

Permalink
Remove deprecated property $_defaultPageType (pimcore#18105)
Browse files Browse the repository at this point in the history
  • Loading branch information
mattamon authored Feb 17, 2025
1 parent 16b3282 commit 5bdcdb7
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 11 deletions.
5 changes: 4 additions & 1 deletion doc/23_Installation_and_Upgrade/09_Upgrade_Notes/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,16 @@

#### [DataObjects]
- Removed deprecated `unserialize()` method from `Pimcore\Model\DataObject\Data\Link`. If not the data is not migrated to the new format, to the new default values, please execute a simple script to resave all links.
- Parameter `$index` of method `setIndex` is not nullable anymore in `Pimcore\Model\DataObject\ClassDefinition\Data`
- Parameter `$index` of method `setIndex` is not nullable anymore in `Pimcore\Model\DataObject\ClassDefinition\Data`.
- Removed deprecated `getThumbnailConfig()` method from `Pimcore\Model\Asset\Image`.

#### [Lib]
- Removed deprecated class `Pimcore\Helper\CsvFormulaFormatter`. Use `\League\Csv\EscapeFormula` instead.
- Removed deprecated `getCachedSymfonyEnvironments()` method from `Pimcore\Tool`.

#### [Navigation]
- Remove deprecated `$_defaultPageType` from `Pimcore\Navigation\Page`.

## Pimcore 11.6.0
### Elements
#### [Documents]
Expand Down
10 changes: 0 additions & 10 deletions lib/Navigation/Page.php
Original file line number Diff line number Diff line change
Expand Up @@ -137,14 +137,6 @@ abstract class Page extends Container
*/
protected array $_customHtmlAttribs = [];

/**
* @deprecated will be removed in Pimcore 12.
*
* The type of page to use when it wasn't set
*
*/
protected static ?string $_defaultPageType = null;

// Initialization:

/**
Expand All @@ -170,8 +162,6 @@ public static function factory(array $options): Url|Page
{
if (isset($options['type'])) {
$type = $options['type'];
} elseif (self::$_defaultPageType != null) {
$type = self::$_defaultPageType;
}

if (isset($type)) {
Expand Down

0 comments on commit 5bdcdb7

Please sign in to comment.