Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning squigglies could be single underline #230

Open
IgorKrupenja opened this issue Sep 24, 2019 · 4 comments
Open

Warning squigglies could be single underline #230

IgorKrupenja opened this issue Sep 24, 2019 · 4 comments

Comments

@IgorKrupenja
Copy link

Describe the solution you'd like
At the moment, warning squigglies use triple underline:
image

Is your feature request related to a problem? Please describe.
I think this hurts readability a bit and all other themes I have seen use single underline, e.g. Light+:

image

Also, I have found no way to modify this using workbench.colorCustomizations

@IgorKrupenja IgorKrupenja changed the title Warning squigglies should be single underline Warning squigglies could be single underline Sep 24, 2019
@trkoch
Copy link

trkoch commented Nov 20, 2019

@krupenja Have you found a workaround?

@IgorKrupenja
Copy link
Author

@trkoch No, I haven't :(

@trkoch
Copy link

trkoch commented Nov 20, 2019

@krupenja Adding "editorWarning.border": "#0000" to workbench.colorCustomizations seems to do the trick, but it feels like a terrible hack. I couldn't make out how to properly reset a color setting.

@IgorKrupenja
Copy link
Author

@trkoch that does the trick but feels hacky, yeah. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants