Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XCFramework is not properly generated for arvm7 architecture #13

Closed
luisrecuenco opened this issue Feb 10, 2021 · 3 comments
Closed

XCFramework is not properly generated for arvm7 architecture #13

luisrecuenco opened this issue Feb 10, 2021 · 3 comments

Comments

@luisrecuenco
Copy link

It seems that from version 14.1.0, the XCFramework no longer has the correct arvm7 slice and it fails to compile with the following message.

Undefined symbols for architecture armv7:
  "_OBJC_CLASS_$_SHKShake", referenced from:
      objc-class-ref in AppDelegate.o
ld: symbol(s) not found for architecture armv7

Version 12.1.0 is properly generated though.

@luisrecuenco
Copy link
Author

I think the problem is that the Package.swift is setting the minimum version to iOS 10 when it should be iOS 11, based on the documentation. iOS 10 devices still require the armv7 architecture for 32 bits, unlike iOS 11.

@david-halapir
Copy link
Contributor

Hi @luisrecuenco ,

Good catch, we bumped the minimum version to iOS11, but looks like we forgot to edit the Package.swift file.
We'll test it out and the next release should contain the fix for this.

Thanks for the detailed report.

David

Shake Team

@david-halapir
Copy link
Contributor

Fixed with the 14.1.3 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants