Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please put your React Native SDK on Github. 🙇 #14

Closed
markymc opened this issue Apr 26, 2021 · 8 comments
Closed

Please put your React Native SDK on Github. 🙇 #14

markymc opened this issue Apr 26, 2021 · 8 comments

Comments

@markymc
Copy link

markymc commented Apr 26, 2021

Hi guys, I see on https://www.npmjs.com/package/@shakebugs/react-native-shake that you're hosted on Bitbucket for your React Native SDK. However, when attempting to look at it (while logged into the Bitbucket), I just get a "We can't let you see this page" error.

Is there a reason it's not hosted on Github? Please consider moving it here. Thanks!

@mstanic-shake
Copy link
Member

Hi @markymc,

We don't have in plan to migrate our repository to Github for now.
However, we are thinking about open sourcing our Bitbucket React Native and Flutter repositories.
If we decide to do so, it will be visible on the Bitbucket very soon.

Regards

@markymc
Copy link
Author

markymc commented Apr 27, 2021

@mstanic0 Thanks for your reply.

Just so you know, it's not a great developer experience to have to go over to Bitbucket for an open source project to inspect the codebase and log issues. I'd strongly suggest you consider hosting on Github, even if it's a mirror of your Github one.

As a note, we're experiencing issues upgrading to your latest React Native SDK on both iOS and Android, and we can't easily browse or share links to the native code to see what's going on and solve our problem.

@mstanic-shake
Copy link
Member

mstanic-shake commented Apr 27, 2021

Thanks for the suggestion, currently our CI/CD is depending on Bitbucket.
We would need to do refactor but currently are focused on delivering new features.

We have to see what is the best approach and see how that fits into our plan, I'll update you here with the final decision.

@markymc
Copy link
Author

markymc commented Apr 27, 2021

Thanks. As I said, even just a mirror that we can inspect the code and log issues in would be good for now. :)

@markymc
Copy link
Author

markymc commented May 10, 2021

@mstanic0 We're now seeing this when trying to run our app on Android:

* What went wrong:
Execution failed for task ':app:checkDebugAarMetadata'.
> Could not resolve all files for configuration ':app:debugRuntimeClasspath'.
   > Could not resolve com.shakebugs.android:shake:10.0.+.
     Required by:
         project :app > project :shakebugs_react-native-shake
      > Failed to list versions for com.shakebugs.android:shake.
         > Unable to load Maven meta-data from https://dl.bintray.com/shake/shake/com/shakebugs/android/shake/maven-metadata.xml.
            > Could not HEAD 'https://dl.bintray.com/shake/shake/com/shakebugs/android/shake/maven-metadata.xml'. Received status code 403 from server: Forbidden

Did something change?

@p-shakebugs
Copy link
Member

@mstanic-shake
Copy link
Member

mstanic-shake commented May 10, 2021

@markymc Check your android/build.gradle file, if you have the following entry please remove it.
maven { url 'https://dl.bintray.com/shake/shake' }

That is an entry required for old version, our native SDK is now hosted on Maven Central.

If you have another question please open a new issue, we'll keep this one for SDK open sourcing.

@ddoric-shake
Copy link

Hi @markymc, as from today we completed the process of open sourcing our React Native SDK and Flutter SDK repositories to Github so inspecting codebase and logging issues will be much easier from now on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants