diff --git a/.jscs.json b/.jscs.json index 2c6a0d186669..4e0292635483 100644 --- a/.jscs.json +++ b/.jscs.json @@ -27,6 +27,12 @@ "requireSpaceBeforeBinaryOperators": ["?", ":", "+", "-", "/", "*", "%", "==", "===", "!=", "!==", ">", ">=", "<", "<=", "&&", "||"], "requireSpaceAfterKeywords": ["if", "else", "for", "while", "do", "switch", "return", "try", "catch"], "requireSpaceBeforeBlockStatements": true, + "requireSpacesInConditionalExpression": { + "afterTest": true, + "beforeConsequent": true, + "afterConsequent": true, + "beforeAlternate": true + }, "requireSpacesInFunction": { "beforeOpeningCurlyBrace": true }, diff --git a/src/ng/compile.js b/src/ng/compile.js index e182243ef864..e1d08e60fd15 100644 --- a/src/ng/compile.js +++ b/src/ng/compile.js @@ -1232,7 +1232,7 @@ function $CompileProvider($provide, $$sanitizeUriProvider) { if (!node) { return 'html'; } else { - return nodeName_(node) !== 'foreignobject' && node.toString().match(/SVG/) ? 'svg': 'html'; + return nodeName_(node) !== 'foreignobject' && node.toString().match(/SVG/) ? 'svg' : 'html'; } } diff --git a/src/ng/filter/orderBy.js b/src/ng/filter/orderBy.js index 078103dea79a..3ad89d545304 100644 --- a/src/ng/filter/orderBy.js +++ b/src/ng/filter/orderBy.js @@ -119,7 +119,7 @@ orderByFilter.$inject = ['$parse']; function orderByFilter($parse) { return function(array, sortPredicate, reverseOrder) { if (!(isArrayLike(array))) return array; - sortPredicate = isArray(sortPredicate) ? sortPredicate: [sortPredicate]; + sortPredicate = isArray(sortPredicate) ? sortPredicate : [sortPredicate]; if (sortPredicate.length === 0) { sortPredicate = ['+']; } sortPredicate = sortPredicate.map(function(predicate) { var descending = false, get = predicate || identity; diff --git a/src/ng/parse.js b/src/ng/parse.js index 6df14a6faede..4b0a2390c8df 100644 --- a/src/ng/parse.js +++ b/src/ng/parse.js @@ -109,10 +109,10 @@ var OPERATORS = extend(createMap(), { } return a; } - return isDefined(b)?b:undefined;}, + return isDefined(b) ? b : undefined;}, '-':function(self, locals, a, b) { a=a(self, locals); b=b(self, locals); - return (isDefined(a)?a:0) - (isDefined(b)?b:0); + return (isDefined(a) ? a : 0) - (isDefined(b) ? b : 0); }, '*':function(self, locals, a, b) {return a(self, locals) * b(self, locals);}, '/':function(self, locals, a, b) {return a(self, locals) / b(self, locals);}, diff --git a/test/helpers/matchers.js b/test/helpers/matchers.js index b0c372127fbc..91407c2f795e 100644 --- a/test/helpers/matchers.js +++ b/test/helpers/matchers.js @@ -45,17 +45,17 @@ beforeEach(function() { toBeTouched: cssMatcher('ng-touched', 'ng-untouched'), toBeAPromise: function() { this.message = valueFn( - "Expected object " + (this.isNot ? "not ": "") + "to be a promise"); + "Expected object " + (this.isNot ? "not " : "") + "to be a promise"); return isPromiseLike(this.actual); }, toBeShown: function() { this.message = valueFn( - "Expected element " + (this.isNot ? "": "not ") + "to have 'ng-hide' class"); + "Expected element " + (this.isNot ? "" : "not ") + "to have 'ng-hide' class"); return !isNgElementHidden(this.actual); }, toBeHidden: function() { this.message = valueFn( - "Expected element " + (this.isNot ? "not ": "") + "to have 'ng-hide' class"); + "Expected element " + (this.isNot ? "not " : "") + "to have 'ng-hide' class"); return isNgElementHidden(this.actual); }, diff --git a/test/helpers/testabilityPatch.js b/test/helpers/testabilityPatch.js index 27f265552ba1..fd55c58c99fc 100644 --- a/test/helpers/testabilityPatch.js +++ b/test/helpers/testabilityPatch.js @@ -152,7 +152,7 @@ function sortedHtml(element, showNgClass) { if (node.nodeName == "#text") { html += node.nodeValue. - replace(/&(\w+[&;\W])?/g, function(match, entity) {return entity?match:'&';}). + replace(/&(\w+[&;\W])?/g, function(match, entity) {return entity ? match : '&';}). replace(//g, '>'); } else if (node.nodeName == "#comment") { diff --git a/test/ng/parseSpec.js b/test/ng/parseSpec.js index 5c313f38e648..f6067ed08d37 100644 --- a/test/ng/parseSpec.js +++ b/test/ng/parseSpec.js @@ -269,54 +269,54 @@ describe('parser', function() { var identity = scope.identity = function(x) { return x; }; // Simple. - expect(scope.$eval('0?0:2')).toEqual(0?0:2); - expect(scope.$eval('1?0:2')).toEqual(1?0:2); + expect(scope.$eval('0?0:2')).toEqual(0 ? 0 : 2); + expect(scope.$eval('1?0:2')).toEqual(1 ? 0 : 2); // Nested on the left. - expect(scope.$eval('0?0?0:0:2')).toEqual(0?0?0:0:2); - expect(scope.$eval('1?0?0:0:2')).toEqual(1?0?0:0:2); - expect(scope.$eval('0?1?0:0:2')).toEqual(0?1?0:0:2); - expect(scope.$eval('0?0?1:0:2')).toEqual(0?0?1:0:2); - expect(scope.$eval('0?0?0:2:3')).toEqual(0?0?0:2:3); - expect(scope.$eval('1?1?0:0:2')).toEqual(1?1?0:0:2); - expect(scope.$eval('1?1?1:0:2')).toEqual(1?1?1:0:2); - expect(scope.$eval('1?1?1:2:3')).toEqual(1?1?1:2:3); - expect(scope.$eval('1?1?1:2:3')).toEqual(1?1?1:2:3); + expect(scope.$eval('0?0?0:0:2')).toEqual(0 ? 0 ? 0 : 0 : 2); + expect(scope.$eval('1?0?0:0:2')).toEqual(1 ? 0 ? 0 : 0 : 2); + expect(scope.$eval('0?1?0:0:2')).toEqual(0 ? 1 ? 0 : 0 : 2); + expect(scope.$eval('0?0?1:0:2')).toEqual(0 ? 0 ? 1 : 0 : 2); + expect(scope.$eval('0?0?0:2:3')).toEqual(0 ? 0 ? 0 : 2 : 3); + expect(scope.$eval('1?1?0:0:2')).toEqual(1 ? 1 ? 0 : 0 : 2); + expect(scope.$eval('1?1?1:0:2')).toEqual(1 ? 1 ? 1 : 0 : 2); + expect(scope.$eval('1?1?1:2:3')).toEqual(1 ? 1 ? 1 : 2 : 3); + expect(scope.$eval('1?1?1:2:3')).toEqual(1 ? 1 ? 1 : 2 : 3); // Nested on the right. - expect(scope.$eval('0?0:0?0:2')).toEqual(0?0:0?0:2); - expect(scope.$eval('1?0:0?0:2')).toEqual(1?0:0?0:2); - expect(scope.$eval('0?1:0?0:2')).toEqual(0?1:0?0:2); - expect(scope.$eval('0?0:1?0:2')).toEqual(0?0:1?0:2); - expect(scope.$eval('0?0:0?2:3')).toEqual(0?0:0?2:3); - expect(scope.$eval('1?1:0?0:2')).toEqual(1?1:0?0:2); - expect(scope.$eval('1?1:1?0:2')).toEqual(1?1:1?0:2); - expect(scope.$eval('1?1:1?2:3')).toEqual(1?1:1?2:3); - expect(scope.$eval('1?1:1?2:3')).toEqual(1?1:1?2:3); + expect(scope.$eval('0?0:0?0:2')).toEqual(0 ? 0 : 0 ? 0 : 2); + expect(scope.$eval('1?0:0?0:2')).toEqual(1 ? 0 : 0 ? 0 : 2); + expect(scope.$eval('0?1:0?0:2')).toEqual(0 ? 1 : 0 ? 0 : 2); + expect(scope.$eval('0?0:1?0:2')).toEqual(0 ? 0 : 1 ? 0 : 2); + expect(scope.$eval('0?0:0?2:3')).toEqual(0 ? 0 : 0 ? 2 : 3); + expect(scope.$eval('1?1:0?0:2')).toEqual(1 ? 1 : 0 ? 0 : 2); + expect(scope.$eval('1?1:1?0:2')).toEqual(1 ? 1 : 1 ? 0 : 2); + expect(scope.$eval('1?1:1?2:3')).toEqual(1 ? 1 : 1 ? 2 : 3); + expect(scope.$eval('1?1:1?2:3')).toEqual(1 ? 1 : 1 ? 2 : 3); // Precedence with respect to logical operators. - expect(scope.$eval('0&&1?0:1')).toEqual(0 && 1?0:1); - expect(scope.$eval('1||0?0:0')).toEqual(1 || 0?0:0); - - expect(scope.$eval('0?0&&1:2')).toEqual(0?0 && 1:2); - expect(scope.$eval('0?1&&1:2')).toEqual(0?1 && 1:2); - expect(scope.$eval('0?0||0:1')).toEqual(0?0 || 0:1); - expect(scope.$eval('0?0||1:2')).toEqual(0?0 || 1:2); - - expect(scope.$eval('1?0&&1:2')).toEqual(1?0 && 1:2); - expect(scope.$eval('1?1&&1:2')).toEqual(1?1 && 1:2); - expect(scope.$eval('1?0||0:1')).toEqual(1?0 || 0:1); - expect(scope.$eval('1?0||1:2')).toEqual(1?0 || 1:2); - - expect(scope.$eval('0?1:0&&1')).toEqual(0?1:0 && 1); - expect(scope.$eval('0?2:1&&1')).toEqual(0?2:1 && 1); - expect(scope.$eval('0?1:0||0')).toEqual(0?1:0 || 0); - expect(scope.$eval('0?2:0||1')).toEqual(0?2:0 || 1); - - expect(scope.$eval('1?1:0&&1')).toEqual(1?1:0 && 1); - expect(scope.$eval('1?2:1&&1')).toEqual(1?2:1 && 1); - expect(scope.$eval('1?1:0||0')).toEqual(1?1:0 || 0); - expect(scope.$eval('1?2:0||1')).toEqual(1?2:0 || 1); + expect(scope.$eval('0&&1?0:1')).toEqual(0 && 1 ? 0 : 1); + expect(scope.$eval('1||0?0:0')).toEqual(1 || 0 ? 0 : 0); + + expect(scope.$eval('0?0&&1:2')).toEqual(0 ? 0 && 1 : 2); + expect(scope.$eval('0?1&&1:2')).toEqual(0 ? 1 && 1 : 2); + expect(scope.$eval('0?0||0:1')).toEqual(0 ? 0 || 0 : 1); + expect(scope.$eval('0?0||1:2')).toEqual(0 ? 0 || 1 : 2); + + expect(scope.$eval('1?0&&1:2')).toEqual(1 ? 0 && 1 : 2); + expect(scope.$eval('1?1&&1:2')).toEqual(1 ? 1 && 1 : 2); + expect(scope.$eval('1?0||0:1')).toEqual(1 ? 0 || 0 : 1); + expect(scope.$eval('1?0||1:2')).toEqual(1 ? 0 || 1 : 2); + + expect(scope.$eval('0?1:0&&1')).toEqual(0 ? 1 : 0 && 1); + expect(scope.$eval('0?2:1&&1')).toEqual(0 ? 2 : 1 && 1); + expect(scope.$eval('0?1:0||0')).toEqual(0 ? 1 : 0 || 0); + expect(scope.$eval('0?2:0||1')).toEqual(0 ? 2 : 0 || 1); + + expect(scope.$eval('1?1:0&&1')).toEqual(1 ? 1 : 0 && 1); + expect(scope.$eval('1?2:1&&1')).toEqual(1 ? 2 : 1 && 1); + expect(scope.$eval('1?1:0||0')).toEqual(1 ? 1 : 0 || 0); + expect(scope.$eval('1?2:0||1')).toEqual(1 ? 2 : 0 || 1); // Function calls. expect(scope.$eval('returnTrue() ? returnString() : returnInt()')).toEqual(returnTrue() ? returnString() : returnInt());