Skip to content

Commit

Permalink
[fuchsia] Timeline events in profile mode to observatory (flutter#15900)
Browse files Browse the repository at this point in the history
This is to address fxb/44063

In all the other modes they will be sent to the systrace
  • Loading branch information
iskakaushik authored Jan 23, 2020
1 parent 1fc17d1 commit 5c9c627
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 2 additions & 1 deletion runtime/dart_vm.cc
Original file line number Diff line number Diff line change
Expand Up @@ -380,7 +380,8 @@ DartVM::DartVM(std::shared_ptr<const DartVMData> vm_data,
args.push_back(old_gen_heap_size_args.c_str());
}

#if defined(OS_FUCHSIA)
#if defined(OS_FUCHSIA) && \
(FLUTTER_RUNTIME_MODE != FLUTTER_RUNTIME_MODE_PROFILE)
PushBackAll(&args, kDartFuchsiaTraceArgs, fml::size(kDartFuchsiaTraceArgs));
PushBackAll(&args, kDartTraceStreamsArgs, fml::size(kDartTraceStreamsArgs));
#endif
Expand Down
2 changes: 2 additions & 0 deletions shell/platform/fuchsia/dart_runner/dart_runner.cc
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,9 @@ const char* kDartVMArgs[] = {
// addressed.
"--no_causal_async_stacks",

#if !defined(FLUTTER_PROFILE)
"--systrace_timeline",
#endif
"--timeline_streams=Compiler,Dart,Debugger,Embedder,GC,Isolate,VM",

#if defined(AOT_RUNTIME)
Expand Down

0 comments on commit 5c9c627

Please sign in to comment.