Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky test create_and_destroy: Attempted to add a new component of type [/datum/component/pellet_cloud] to a qdeleting parent of type [/obj/item/mine/pressure/explosive/fire/live]! #3891

Closed
github-actions bot opened this issue Dec 7, 2024 · 1 comment · Fixed by #3907
Closed

Flaky test create_and_destroy: Attempted to add a new component of type [/datum/component/pellet_cloud] to a qdeleting parent of type [/obj/item/mine/pressure/explosive/fire/live]! #3891

github-actions bot opened this issue Dec 7, 2024 · 1 comment · Fixed by #3907
Labels
🤖 Flaky Test Report Stale All falls to entropy eventually.

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2024

Flaky tests were detected in this test run. This means that there was a failure that was cleared when the tests were simply restarted.
Failures:

create_and_destroy: [2024-12-07 18:05:01] Runtime in code/datums/components/_component.dm,408: Attempted to add a new component of type [/datum/component/pellet_cloud] to a qdeleting parent of type [/obj/item/mine/pressure/explosive/fire/live]!
proc name:  AddComponent (/datum/proc/_AddComponent)
src: the G-82 Incindeary (/obj/item/mine/pressure/explosive/fire/live)
src.loc: null
call stack:
the G-82 Incindeary (/obj/item/mine/pressure/explosive/fire/live):  AddComponent(/list (/list))
the G-82 Incindeary (/obj/item/mine/pressure/explosive/fire/live): mine effect(null)
the G-82 Incindeary (/obj/item/mine/pressure/explosive/fire/live): mine effect(null)
the G-82 Incindeary (/obj/item/mine/pressure/explosive/fire/live): blast now(null)
/datum/callback (/datum/callback): InvokeAsync()
Timer (/datum/controller/subsystem/timer): fire(0)
Timer (/datum/controller/subsystem/timer): ignite(0)
Master (/datum/controller/master): RunQueue()
Master (/datum/controller/master): Loop(2)
Master (/datum/controller/master): StartProcessing(0) at code/datums/components/_component.dm:408
@github-actions GitHub Actions
Copy link
Contributor Author

This flaky fail has not been detected in 7 days. If it doesn't show up again in another 7 days, it will be auto-closed.

@github-actions github-actions bot added the Stale All falls to entropy eventually. label Dec 15, 2024
@MarkSuckerberg MarkSuckerberg mentioned this issue Dec 16, 2024
Merged
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 23, 2024
github-merge-queue bot pushed a commit that referenced this issue Jan 6, 2025
@MarkSuckerberg @FalloutFalcon
More flakey fixes (#3907)
c067566 
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
Fixes: #3779
Fixes: #3855 
Fixes: #3647
Fixes: #3901
Fixes: #3891

still working on the wet floor one (#3681)

## Why It's Good For The Game
grunts in pain

## Changelog

:cl:
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

---------

Co-authored-by: FalloutFalcon <[email protected]>
MrCat15352 pushed a commit to MrCat15352/MrCat that referenced this issue Jan 8, 2025
@MarkSuckerberg @FalloutFalcon @MrCat15352
More flakey fixes (shiptest-ss13#3907)
3fa100f 
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
Fixes: shiptest-ss13#3779
Fixes: shiptest-ss13#3855 
Fixes: shiptest-ss13#3647
Fixes: shiptest-ss13#3901
Fixes: shiptest-ss13#3891

still working on the wet floor one (shiptest-ss13#3681)

## Why It's Good For The Game
grunts in pain

## Changelog

:cl:
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

---------

Co-authored-by: FalloutFalcon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🤖 Flaky Test Report Stale All falls to entropy eventually.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

More flakey fixes MarkSuckerberg/Shiptest
0 participants