Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wouldn't it be a memory leak? #49

Closed
kgdev opened this issue Feb 1, 2018 · 4 comments
Closed

Wouldn't it be a memory leak? #49

kgdev opened this issue Feb 1, 2018 · 4 comments

Comments

@kgdev
Copy link

kgdev commented Feb 1, 2018

redux-io/src/denormalizer/getCollection.js

Line 9 in 14e84d2

const resolveStorageMap = _.memoize((state, schemaPaths) => createSchemasMap(state, schemaPaths));

@kgdev
Copy link
Author

kgdev commented Feb 1, 2018

memoize does not clear the history.

@kgdev kgdev changed the title Would it be a memory leak? Wouldn't it be a memory leak? Feb 1, 2018
@kgdev
Copy link
Author

kgdev commented Feb 1, 2018

Also, by default _.memoize only caches the first argument.

@vedrani
Copy link
Contributor

vedrani commented Mar 26, 2018

Thanks for the info, you are absolutely right. I will fix it as soon as possible. What version of redux-io are you using?

@vedrani
Copy link
Contributor

vedrani commented Jul 13, 2018

Solved with 3.1.0-beta.10

@vedrani vedrani closed this as completed Jul 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kgdev @vedrani