Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyper Config.Unmarshal() seems broken #127

Open
RmbRT opened this issue Dec 13, 2024 · 0 comments
Open

Keyper Config.Unmarshal() seems broken #127

RmbRT opened this issue Dec 13, 2024 · 0 comments

Comments

@RmbRT
Copy link

RmbRT commented Dec 13, 2024

During my work on the TEE fortification of the keyper, I noticed there was no test for loading a TOML config. I wrote a test and it seems like somehow, the Viper object, while containing all the keys and values, is unable to properly transfer those into the Config object.

Calling .Unmarshal() on an empty Config object results in a segfault, because the keys are nil. If I GenerateKeys() and then call Unmarshal(), it does not panic, but all values seem to be left as 0's (default initialised), and the keys remain the same as when they were generated.

I wrote a test case for that in the TEE branch over at perun-network/shutter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant