From 2d92e9ade3d325f239d922a47e7595256a109000 Mon Sep 17 00:00:00 2001 From: Antonio Salazar Cardozo Date: Thu, 10 Mar 2022 16:49:28 -0500 Subject: [PATCH] Tally -> Tally Ho renames throughout --- CONTRIBUTING.md | 14 +++++++------- README.md | 6 +++--- babel.config.js | 2 +- background/README.md | 8 ++++---- background/package.json | 2 +- dev-utils/local-chain/package.json | 2 +- package.json | 2 +- provider-bridge-shared/package.json | 2 +- provider-bridge/package.json | 2 +- ui/README.md | 9 +++++++-- .../AccountsNotificationPanelAccounts.tsx | 2 +- ui/package.json | 2 +- ui/public/popup.html | 2 +- ui/public/tab.html | 2 +- window-provider/package.json | 2 +- 15 files changed, 32 insertions(+), 27 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index a1ca57bd86..67f66f49d0 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -1,10 +1,10 @@ -# Tally Contribution Guide +# Tally Ho Contribution Guide 👍🎉 First off, thanks for taking the time to contribute! 🎉👍 Contributions are welcome from anyone on the internet, and even the smallest of fixes are appreciated! -The following is a set of guidelines for contributing to Tally and its +The following is a set of guidelines for contributing to Tally Ho and its packages. These are mostly guidelines, not rules. Use your best judgment, and feel free to propose changes to this document in a pull request. While the team works towards a first release, bigger contributions will be slow-rolled or @@ -13,8 +13,8 @@ to them very soon! More below. ## Deciding What to Work On -Tally is currently being built by a core team in collaboration with a community -on the [Tally Community Discord server](https://chat.tally.cash). **Discord is +Tally Ho is currently being built by a core team in collaboration with a community +on the [Tally Ho Community Discord server](https://chat.tally.cash). **Discord is the right place to start discussions on new features and bugs.** The community on Discord, led by a few designated folks will help to funnel these into well-organized GitHub issues for features and bugs, as well as organize folks @@ -23,7 +23,7 @@ will be charged with reviewing, critiquing, and ultimately merging new work. ### Short term: Limited Review -In Q4 2021/Q1 2022, Tally is in a heads down sprint to a series of initial +In Q4 2021/Q1 2022, Tally Ho is in a heads down sprint to a series of initial releases. This means PRs with feature contributions _may_ get closed because the team does not have time to review them properly. We still deeply appreciate these contributions, and are not planning on forgetting them! When PRs are @@ -69,14 +69,14 @@ code base. ### Commit Signing -Commits on the Tally repository are all required to be signed. No PR will be +Commits on the Tally Ho repository are all required to be signed. No PR will be merged if it has unsigned commits. See the [GitHub documentation on commit signing](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification) to get it set up. ### Continuous Integration -Tally uses GitHub Actions for continuous integration. All Actions jobs +Tally Ho uses GitHub Actions for continuous integration. All Actions jobs (including tests, linting) must be green to merge a PR. ### Pre-commit diff --git a/README.md b/README.md index c9b1969743..aa11265f2c 100644 --- a/README.md +++ b/README.md @@ -4,7 +4,7 @@ src="./github_cover@2x.png" width="630" /> -[Tally](https://blog.tally.cash/a-community-owned-wallet-for-the-new-internet/) +[Tally Ho](https://blog.tally.cash/a-community-owned-wallet-for-the-new-internet/) is a community owned and operated Web3 wallet, built as a [browser extension](https://browserext.github.io/browserext/). @@ -18,7 +18,7 @@ spirit of community ownership. We can do better. -Tally will be +Tally Ho will be - Fairly launched ⚖️ - Sustainably aligned with users 🤲 @@ -140,7 +140,7 @@ $ yarn start ### Commit signing -Commits on the Tally repository are all required to be signed. +Commits on the Tally Ho repository are all required to be signed. No PR will be merged if it has unsigned commits. See the [GitHub documentation on commit signing](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification) to get it set up. diff --git a/babel.config.js b/babel.config.js index 8ca0461125..90c62b319d 100644 --- a/babel.config.js +++ b/babel.config.js @@ -1,4 +1,4 @@ -// Global config for all babel-affected Tally packages. +// Global config for all babel-affected Tally Ho packages. module.exports = { plugins: ["styled-jsx/babel"], presets: [ diff --git a/background/README.md b/background/README.md index 02734d3282..0b48561f0e 100644 --- a/background/README.md +++ b/background/README.md @@ -1,7 +1,7 @@ -# Tally Background +# Tally Ho Background -The Tally Background package can effectively be considered the background script for the -Tally extension. It is designed to connect to external data providers including +The Tally Ho Background package can effectively be considered the background script for the +Tally Ho extension. It is designed to connect to external data providers including Ethereum nodes, as well as specific providers like Alchemy and Blocknative that may enable specific functionality beyond the standard node functions. It constructs a data model in the form of a [Redux](https://redux.js.org) store, which is @@ -80,7 +80,7 @@ The following diagram describes the flow of data and events at a high level: ## Public API -The only public API of the Tally Background package is what is exported directly on +The only public API of the Tally Ho Background package is what is exported directly on [`index.ts`](./index.ts). No submodule API is considered public, and all such APIs are subject to arbitrary change without warning. Any API from a child module that is meant for public consumption is re-exported in `index.ts`. diff --git a/background/package.json b/background/package.json index 5e3c10f812..22ac776185 100644 --- a/background/package.json +++ b/background/package.json @@ -1,7 +1,7 @@ { "name": "@tallyho/tally-background", "version": "0.0.1", - "description": "Tally, the community owned and operated Web3 wallet: api implementation.", + "description": "Tally Ho, the community owned and operated Web3 wallet: api implementation.", "main": "index.ts", "repository": "git@github.com:thesis/tally-extension.git", "author": "Matt Luongo ", diff --git a/dev-utils/local-chain/package.json b/dev-utils/local-chain/package.json index d2460f126c..dc036612c5 100644 --- a/dev-utils/local-chain/package.json +++ b/dev-utils/local-chain/package.json @@ -1,6 +1,6 @@ { "name": "local-chain", - "description": "Local chain setup to support Tally extension development.", + "description": "Local chain setup to support Tally Ho extension development.", "license": "GPL-3.0", "private": true, "repository": "https://github.com/tallycash/extension", diff --git a/package.json b/package.json index 7bd3b38a4f..7e9e4c1fe8 100644 --- a/package.json +++ b/package.json @@ -2,7 +2,7 @@ "name": "@tallyho/tally-extension", "private": true, "version": "0.12.1", - "description": "Tally, the community owned and operated Web3 wallet.", + "description": "Tally Ho, the community owned and operated Web3 wallet.", "main": "index.js", "repository": "git@github.com:thesis/tally-extension.git", "author": "Matt Luongo ", diff --git a/provider-bridge-shared/package.json b/provider-bridge-shared/package.json index e7e2abd3a7..aa40dd8d34 100644 --- a/provider-bridge-shared/package.json +++ b/provider-bridge-shared/package.json @@ -1,7 +1,7 @@ { "name": "@tallyho/provider-bridge-shared", "version": "0.0.1", - "description": "Tally, the community owned and operated Web3 wallet: provider bridge to connect the in-page provider with the background script.", + "description": "Tally Ho, the community owned and operated Web3 wallet: provider bridge to connect the in-page provider with the background script.", "main": "index.ts", "repository": "git@github.com:thesis/tally-extension.git", "author": "Greg Nagy ", diff --git a/provider-bridge/package.json b/provider-bridge/package.json index 91b751d270..b3111498c2 100644 --- a/provider-bridge/package.json +++ b/provider-bridge/package.json @@ -1,7 +1,7 @@ { "name": "@tallyho/provider-bridge", "version": "0.0.1", - "description": "Tally, the community owned and operated Web3 wallet: provider bridge to connect the in-page provider with the background script.", + "description": "Tally Ho, the community owned and operated Web3 wallet: provider bridge to connect the in-page provider with the background script.", "main": "index.ts", "repository": "git@github.com:thesis/tally-extension.git", "author": "Greg Nagy ", diff --git a/ui/README.md b/ui/README.md index 8699ba246a..56033e0995 100644 --- a/ui/README.md +++ b/ui/README.md @@ -1,8 +1,13 @@ -# Tally Extension Frontend 🐕 +# Tally Ho Extension Frontend 🐕 ![Screen + Browser Mock](https://user-images.githubusercontent.com/1918798/125732391-29da0e00-0796-49bb-895d-35de187b141d.png) -Welcome to the frontend portion of the Tally browser extension. This is the React portion of the codebase which handles UI related states, and communicates with the background script API `@tallyho/tally-background`. The intent is for all communication with outside APIs to strictly happen within `@tallyho/tally-background`, not here. This frontend only contains what's needed to provide the visual goodness! +Welcome to the frontend portion of the Tally Ho browser extension. This is the +React portion of the codebase which handles UI related states, and communicates +with the background script API `@tallyho/tally-background`. The intent is for +all communication with outside APIs to strictly happen within +`@tallyho/tally-background`, not here. This frontend only contains what's +needed to provide the visual goodness! ## Prerequisites ✍️ diff --git a/ui/components/AccountsNotificationPanel/AccountsNotificationPanelAccounts.tsx b/ui/components/AccountsNotificationPanel/AccountsNotificationPanelAccounts.tsx index 78dbe88fc1..b4db61b2ab 100644 --- a/ui/components/AccountsNotificationPanel/AccountsNotificationPanelAccounts.tsx +++ b/ui/components/AccountsNotificationPanel/AccountsNotificationPanelAccounts.tsx @@ -33,7 +33,7 @@ const walletTypeDetails: { [key in AccountType]: WalletTypeInfo } = { icon: "./images/imported@2x.png", }, [AccountType.Internal]: { - title: "Tally", + title: "Tally Ho", icon: "./images/tally_reward@2x.png", // FIXME: Icon is cut off - we should get a better one }, [AccountType.Ledger]: { diff --git a/ui/package.json b/ui/package.json index f5d4ecd3e7..376ecb6902 100644 --- a/ui/package.json +++ b/ui/package.json @@ -1,7 +1,7 @@ { "name": "@tallyho/tally-ui", "version": "0.0.1", - "description": "Tally, the community owned and operated Web3 wallet: UI package.", + "description": "Tally Ho, the community owned and operated Web3 wallet: UI package.", "main": "index.ts", "repository": "git@github.com:thesis/tally-extension.git", "author": "Matt Luongo ", diff --git a/ui/public/popup.html b/ui/public/popup.html index b1d72449e5..14c1749daa 100644 --- a/ui/public/popup.html +++ b/ui/public/popup.html @@ -1,7 +1,7 @@ - Tally + Tally Ho diff --git a/ui/public/tab.html b/ui/public/tab.html index 5004ff4ee3..0eedc61c99 100644 --- a/ui/public/tab.html +++ b/ui/public/tab.html @@ -2,7 +2,7 @@ - Tally + Tally Ho diff --git a/window-provider/package.json b/window-provider/package.json index 17b22200ab..aba08843fc 100644 --- a/window-provider/package.json +++ b/window-provider/package.json @@ -1,7 +1,7 @@ { "name": "@tallyho/window-provider", "version": "0.0.1", - "description": "Tally, the community owned and operated Web3 wallet: window provider is responsible for creating the in-page object for communication.", + "description": "Tally Ho, the community owned and operated Web3 wallet: window provider is responsible for creating the in-page object for communication.", "main": "index.ts", "repository": "git@github.com:thesis/tally-extension.git", "author": "Greg Nagy ",