Skip to content

Commit

Permalink
[cobalt-client]: Remove event_code ASSERT.
Browse files Browse the repository at this point in the history
This was added due to the Cobalt Service ignoring this data,
and making everything be 0 (not yet implemented). But it is,
still valid to use it, though it would be a good idea to reserve
0 for unknown.

TESTS=cobalt-client-tests

Change-Id: I5a3e81eeaa0ea6885f0e4f8083309c0bb585ea4e
  • Loading branch information
gevp authored and CQ bot account: [email protected] committed Nov 5, 2018
1 parent 88208e6 commit ed473c0
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions system/ulib/cobalt-client/collector.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,6 @@ Collector::~Collector() {
};

Histogram Collector::AddHistogram(const HistogramOptions& options) {
ZX_DEBUG_ASSERT_MSG(options.event_code > 0, "event_type_index 0 value is reserved.");
ZX_DEBUG_ASSERT_MSG(remote_histograms_.size() < remote_histograms_.capacity(),
"Exceeded pre-allocated histogram capacity.");
RemoteHistogram::EventBuffer buffer;
Expand All @@ -97,7 +96,6 @@ Histogram Collector::AddHistogram(const HistogramOptions& options) {
}

Counter Collector::AddCounter(const MetricOptions& options) {
ZX_DEBUG_ASSERT_MSG(options.event_code > 0, "event_type_index 0 value is reserved.");
ZX_DEBUG_ASSERT_MSG(remote_counters_.size() < remote_counters_.capacity(),
"Exceeded pre-allocated counter capacity.");
RemoteCounter::EventBuffer buffer;
Expand Down

0 comments on commit ed473c0

Please sign in to comment.