Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in neighbor feature functions #36

Open
Wang4758 opened this issue May 27, 2019 · 3 comments
Open

Bug in neighbor feature functions #36

Wang4758 opened this issue May 27, 2019 · 3 comments
Milestone
v0.8

Comments

@Wang4758
Copy link

Hi there,

In the function Base.get(::Feature_Dist_Front) and Base.get(::Feature_Dist_Rear)here, you can pass censor_hi as argument. But it is not used insided the function. Instead hard code values are used. Is that a bug?
@MaximeBouton
Copy link
Member

I think you are right it seems like a bug. Could you submit a PR that fixes it and tests the function?
The overall feature extraction part of the repo has not been tested thoroughly, do not hesitate to report bugs and contribute with fixes and tests.

@MaximeBouton
Copy link
Member

#70

@MaximeBouton MaximeBouton added this to the v0.8 milestone Mar 11, 2020
@MaximeBouton
Copy link
Member

the feature extraction mechanism has been redesigned see https://github.com/sisl/AutomotiveSimulator.jl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.8
Development

No branches or pull requests
2 participants
@MaximeBouton @Wang4758