Fixed Z not matching on where clause Feature points.

This issues fixes an issue where a search command with a where clause using the "z" field would not match correctly for point that where contained inside a GeoJSON Feature type. Tile38 now extracts the Z coordinate from Point and Feature/Point types. fixes tidwall#622
skcsg · Sep 29, 2021 · de59d23 · de59d23
1 parent 4f4e168
commit de59d23
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 18 deletions.
diff --git a/internal/server/crud.go b/internal/server/crud.go
@@ -183,10 +183,7 @@ func (server *Server) cmdGet(msg *Message) (resp.Value, error) {
 			buf.Write(appendJSONSimplePoint(nil, o))
 		} else {
 			point := o.Center()
-			var z float64
-			if gPoint, ok := o.(*geojson.Point); ok {
-				z = gPoint.Z()
-			}
+			z := extractZCoordinate(o)
 			if z != 0 {
 				vals = append(vals, resp.ArrayValue([]resp.Value{
 					resp.StringValue(strconv.FormatFloat(point.Y, 'f', -1, 64)),

diff --git a/internal/server/json.go b/internal/server/json.go
@@ -133,10 +133,7 @@ func appendJSONSimpleBounds(dst []byte, o geojson.Object) []byte {
 
 func appendJSONSimplePoint(dst []byte, o geojson.Object) []byte {
 	point := o.Center()
-	var z float64
-	if gPoint, ok := o.(*geojson.Point); ok {
-		z = gPoint.Z()
-	}
+	z := extractZCoordinate(o)
 	dst = append(dst, `{"lat":`...)
 	dst = strconv.AppendFloat(dst, point.Y, 'f', -1, 64)
 	dst = append(dst, `,"lon":`...)

diff --git a/internal/server/scanner.go b/internal/server/scanner.go
@@ -214,6 +214,19 @@ func (sw *scanWriter) writeFoot() {
 	}
 }
 
+func extractZCoordinate(o geojson.Object) float64 {
+	for {
+		switch g := o.(type) {
+		case *geojson.Point:
+			return g.Z()
+		case *geojson.Feature:
+			o = g.Base()
+		default:
+			return 0
+		}
+	}
+}
+
 func (sw *scanWriter) fieldMatch(fields []float64, o geojson.Object) (fvals []float64, match bool) {
 	var z float64
 	var gotz bool
@@ -222,9 +235,7 @@ func (sw *scanWriter) fieldMatch(fields []float64, o geojson.Object) (fvals []fl
 		for _, where := range sw.wheres {
 			if where.field == "z" {
 				if !gotz {
-					if point, ok := o.(*geojson.Point); ok {
-						z = point.Z()
-					}
+					z = extractZCoordinate(o)
 				}
 				if !where.match(z) {
 					return
@@ -270,9 +281,7 @@ func (sw *scanWriter) fieldMatch(fields []float64, o geojson.Object) (fvals []fl
 		for _, where := range sw.wheres {
 			if where.field == "z" {
 				if !gotz {
-					if point, ok := o.(*geojson.Point); ok {
-						z = point.Z()
-					}
+					z = extractZCoordinate(o)
 				}
 				if !where.match(z) {
 					return
@@ -455,10 +464,7 @@ func (sw *scanWriter) writeObject(opts ScanWriterParams) bool {
 				vals = append(vals, resp.StringValue(opts.o.String()))
 			case outputPoints:
 				point := opts.o.Center()
-				var z float64
-				if point, ok := opts.o.(*geojson.Point); ok {
-					z = point.Z()
-				}
+				z := extractZCoordinate(opts.o)
 				if z != 0 {
 					vals = append(vals, resp.ArrayValue([]resp.Value{
 						resp.FloatValue(point.Y),