Skip to content

Latest commit

 

History

History
32 lines (17 loc) · 1.01 KB

103.md

File metadata and controls

32 lines (17 loc) · 1.01 KB

Agreeable Amethyst Pigeon

medium

audit

Summary

SolverVault contract with one potential vulnerability found.

Vulnerability Detail

Improper Access Control Severity: High The contract relies on access control roles to restrict sensitive functions like deposits, withdrawals, pausing etc. However, the deployer is granted all roles by default which could allow them full control over the contract.

Impact

The deployer would be able to abuse their powerful permissions like extracting funds, pausing the contract, modifying parameters without restrictions.

Code Snippet

https://github.com/sherlock-audit/2023-12-symm-io/blob/main/solver-vaults/contracts/SolverVaults.sol#L80-L86

https://github.com/sherlock-audit/2023-12-symm-io/blob/main/solver-vaults/contracts/SolverVaults.sol#L92-L95

Tool used

Manual Review

Recommendation

The deployer role should be separate from the other roles. Roles should be assigned to designated addresses instead of the deployer by default for proper separation of privileges.