Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

401 Authentication error with Phone Numbers #83

Closed
ameer1234567890 opened this issue May 4, 2020 · 7 comments
Closed

401 Authentication error with Phone Numbers #83

ameer1234567890 opened this issue May 4, 2020 · 7 comments
Labels
enhancement New feature or request

Comments

@ameer1234567890
Copy link

I am getting 401 Authentication error with phone numbers as login email. I do use the country code and it gives 401 even for getRegion requests. I tried using another account with an email address and it works.

@ttz642
Copy link
Contributor

ttz642 commented May 4, 2020

Have you tried using the phone number to log in directly with the app on a mobile? Sounds more likely a problem with the server than ewelink-api.

@ameer1234567890
Copy link
Author

Yes, I have tried and it works.

@skydiver
Copy link
Owner

hey @ameer1234567890

i was trying to make this change but i wasn't able to test (cannot use phone with my account, looks like the phone is only available on China)

maybe i can make a branch so you can test locally ?

@skydiver skydiver added the enhancement New feature or request label May 19, 2020
@ameer1234567890
Copy link
Author

Yes please

@skydiver
Copy link
Owner

skydiver commented May 22, 2020

Hey @ameer1234567890

In the next days version 3.0 will be release with support for login using phone number.

You can test this branch: release/3.0.0

Let me know if works for you.

Thanks.-

@ameer1234567890
Copy link
Author

@skydiver I have tested and can confirm that release/3.0.0 branch works for login using phone number. I specified phone number as phoneNumber: '+9609977444' where +960 is the country code. I think it would be a better idea to make a note at class-instantiation.md to include country code as a prefix to phone number. Highly appreciated.

@skydiver
Copy link
Owner

Thanks for testing @ameer1234567890

Here is the updated document: https://github.com/skydiver/ewelink-api/blob/668d60419d8aa12163372e3d7d79d97756bb2f97/docs/class-instantiation.md

Do you have any suggestion? Feel free to update the file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants