SecurityTransactionManager.GetOrderTicket - Faster implementation

skyfyl · Jan 5, 2016 · 2a752f8 · 2a752f8
1 parent 05e620e
commit 2a752f8
Show file tree

Hide file tree

Showing 5 changed files with 32 additions and 1 deletion.
diff --git a/Common/Securities/IOrderProvider.cs b/Common/Securities/IOrderProvider.cs
@@ -50,6 +50,13 @@ public interface IOrderProvider
         /// <returns>An enumerable of <see cref="OrderTicket"/> matching the specified <paramref name="filter"/></returns>
         IEnumerable<OrderTicket> GetOrderTickets(Func<OrderTicket, bool> filter = null);
 
+        /// <summary>
+        /// Gets the order ticket for the specified order id. Returns null if not found
+        /// </summary>
+        /// <param name="orderId">The order's id</param>
+        /// <returns>The order ticket with the specified id, or null if not found</returns>
+        OrderTicket GetOrderTicket(int orderId);
+
         /// <summary>
         /// Gets all orders matching the specified filter. Specifying null will return an enumerable
         /// of all orders.

diff --git a/Common/Securities/SecurityTransactionManager.cs b/Common/Securities/SecurityTransactionManager.cs
@@ -191,7 +191,7 @@ public IEnumerable<OrderTicket> GetOrderTickets(Func<OrderTicket, bool> filter =
         /// <returns>The order ticket with the specified id, or null if not found</returns>
         public OrderTicket GetOrderTicket(int orderId)
         {
-            return GetOrderTickets(x => x.OrderId == orderId).FirstOrDefault();
+            return _orderProcessor.GetOrderTicket(orderId);
         }
 
         /// <summary>

diff --git a/Engine/TransactionHandlers/BrokerageTransactionHandler.cs b/Engine/TransactionHandlers/BrokerageTransactionHandler.cs
@@ -315,6 +315,18 @@ public IEnumerable<OrderTicket> GetOrderTickets(Func<OrderTicket, bool> filter =
             return _orderTickets.Select(x => x.Value).Where(filter ?? (x => true));
         }
 
+        /// <summary>
+        /// Gets the order ticket for the specified order id. Returns null if not found
+        /// </summary>
+        /// <param name="orderId">The order's id</param>
+        /// <returns>The order ticket with the specified id, or null if not found</returns>
+        public OrderTicket GetOrderTicket(int orderId)
+        {
+            OrderTicket ticket;
+            _orderTickets.TryGetValue(orderId, out ticket);
+            return ticket;
+        }
+
         #endregion
 
         /// <summary>

diff --git a/Tests/Brokerages/OrderProvider.cs b/Tests/Brokerages/OrderProvider.cs
@@ -66,6 +66,11 @@ public IEnumerable<OrderTicket> GetOrderTickets(Func<OrderTicket, bool> filter =
             throw new NotImplementedException("This method has not been implemented");
         }
 
+        public OrderTicket GetOrderTicket(int orderId)
+        {
+            throw new NotImplementedException("This method has not been implemented");
+        }
+
         public IEnumerable<Order> GetOrders(Func<Order, bool> filter)
         {
             return _orders.Where(filter);

diff --git a/Tests/Common/Securities/SecurityPortfolioManagerTests.cs b/Tests/Common/Securities/SecurityPortfolioManagerTests.cs
@@ -541,6 +541,13 @@ public IEnumerable<OrderTicket> GetOrderTickets(Func<OrderTicket, bool> filter =
                 return _tickets.Values.Where(filter ?? (x => true));
             }
 
+            public OrderTicket GetOrderTicket(int orderId)
+            {
+                OrderTicket ticket;
+                _tickets.TryGetValue(orderId, out ticket);
+                return ticket;
+            }
+
             public IEnumerable<Order> GetOrders(Func<Order, bool> filter = null)
             {
                 return _orders.Values.Where(filter ?? (x => true));