Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI/UX submit button in comment editor should not be right next to the edit issue button #739

Open
craigfowler opened this issue Sep 21, 2017 · 4 comments
Labels

Comments

@craigfowler
Copy link

craigfowler commented Sep 21, 2017

In the new "advanced editing functionality" for an issue comment, the button to submit the comment is right next to the button to "edit the issue". This makes it too easy to press it by accident.

What's more, because of the icon for the edit issue button (a pencil) and it's prominence it's actually more eye-catching than the submit comment button.

The problematic side to this is that - if you do click the edit issue button by accident, your comment gets discarded because the app goes to the 'edit issue' screen.

@craigfowler
Copy link
Author

Here's an example of what I mean - the buttons in the top right.

screenshot_2017-09-21_225245

@craigfowler
Copy link
Author

Tangentially related to #358.

@Tunous
Copy link
Collaborator

Tunous commented Sep 22, 2017

That's a bug caused by the same thing as #671. This button was supposed to hide when comment editor is expanded.

@Tunous Tunous added the bug label Sep 22, 2017
@maniac103
Copy link
Collaborator

maniac103 commented Sep 26, 2017

@Tunous I fixed #671, but what exactly should make FAB hide when scrolling the app bar?

Edit: It's this check I suppose, which for some reason makes the FAB hide in the PR activity, but not in the issue activity (perhaps due to tabs?)

Another edit: It's definitely due to the tabs; unfortunately I don't see a straightforward way to influence that behavior :-(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants