Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider support the Bad metrics from OpenSLO #186

Open
weyert opened this issue Oct 27, 2021 · 2 comments
Open

Consider support the Bad metrics from OpenSLO #186

weyert opened this issue Oct 27, 2021 · 2 comments

Comments

@weyert
Copy link

weyert commented Oct 27, 2021

Recently the OpensLO added support to allow defining bad / totals metrics for SLO. See also this commit in OpensLO repo:
OpenSLO/OpenSLO@0225725

I was curious what's involved to add support for this into Sloth? Do you think this is achievable for someone who doesn't have any Go programming experience (me)?

@slok
Copy link
Owner

slok commented Nov 1, 2021

Hi @weyert!

Thanks for the update, we could add support indeed. You could give it a try indeed. I think that is not hard and a good exercise. I can point you to the place where this is happening (without telling you exactly so you can learn 😄) and give it a shot.

If it's taking too much time or you are lost I can do it myself and explain the PR to you if you want.

For now... https://github.com/slok/sloth/tree/main/internal/openslo

@weyert
Copy link
Author

weyert commented Nov 1, 2021

Thank you, @slok. Sounds like a plan!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants