Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long run of slo and slo versioning #500

Open
freeseacher opened this issue Apr 27, 2023 · 3 comments
Open

Long run of slo and slo versioning #500

freeseacher opened this issue Apr 27, 2023 · 3 comments

Comments

@freeseacher
Copy link

From time to time we need to adjust queries or labels for slo.
as for now changing labels will break slo calculation for changed.

I propose to add label (?) slo_version to rules calculation and that label to the calculations of

  • slo:current_burn_rate:ratio
  • slo:period_burn_rate:ratio
  • slo:period_error_budget_remaining:ratio
  • alerts
    that would be enough to create different version of slo that can be tracked independently
@ervinb
Copy link

ervinb commented May 25, 2023

I worked around this limitation by simply having the revision in the SLO name.

For example

  slos:
    name: http-availability-rev-1 
    description: 99.5% of the requests should be successful for the user-facing API
    ...

becomes

  slos:
    name: http-availability-rev-2
    description: 99.5% of the requests should be successful for the user-facing API
    ...

which results in a new SLO, while being able to track the previous one - the same behavior you'd get with having the slo_version label.

@freeseacher
Copy link
Author

at the end of the day we got the same idea but we've introduced Version filed in spec.
something like this.
a.txt

i believe this works should be done in different way with introduction of prometheus/v2 kind. and we are not sure if it must go to upstream because of this.

@ishantanu
Copy link

We are currently using the workaround by adding the version in the SLO name. But, in terms of visualising them in Grafana, this means all versions of SLO are shown. There are cases where we moved away from v1 SLO to v2, which means we do not want to track v1 SLO anymore. However, it still shows up on the dashboard.

Has anyone found a way to deal with this situation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants