Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

works only when URL fully matches #6

Open
skyboyer opened this issue Jul 25, 2014 · 4 comments
Open

works only when URL fully matches #6

skyboyer opened this issue Jul 25, 2014 · 4 comments

Comments

@skyboyer
Copy link

if I use "http://localhost:8080" as trigger URL plugin does not start background requesting for URL based on given. E.g. "http://localhost:8080/test" does not start requesting.

@mhenry1384
Copy link

Here's a version that allows you to put a wildcard (*) at the end of the trigger URL.

https://chrome.google.com/webstore/detail/staying-alive-with-wildca/lkdnaojfhnjkophgbnmfaciclaghffpe

Any chance we can get this fix put in the official build of Staying Alive? All I did was modify isUriMatch in lib.js:

DomainRule.prototype.isUriMatch = function (uri) {
ret = uri === this.uri || (uri === (this.uri + '/') ) || uri === this.loopUri || (uri === (this.loopUri + '/') );
if (!ret && this.uri.endsWith("*")) {
ret = (uri.indexOf(this.uri.slice(0,-1)) === 0);
}

return !!ret;

}

@lingfish
Copy link

Yes... this should be merged. No wildcards is annoying.

@tksoh
Copy link

tksoh commented Jul 23, 2020

Here's a version that allows you to put a wildcard (*) at the end of the trigger URL.

https://chrome.google.com/webstore/detail/staying-alive-with-wildca/lkdnaojfhnjkophgbnmfaciclaghffpe

Any chance we can get this fix put in the official build of Staying Alive? All I did was modify isUriMatch in lib.js:

DomainRule.prototype.isUriMatch = function (uri) {
ret = uri === this.uri || (uri === (this.uri + '/') ) || uri === this.loopUri || (uri === (this.loopUri + '/') );
if (!ret && this.uri.endsWith("*")) {
ret = (uri.indexOf(this.uri.slice(0,-1)) === 0);
}

return !!ret;

}

where can we find the git repo for this version? Thanks.

@lucaspottersky
Copy link

as a workaround i think you can just leave 1 tab open in that fixed URL
and work in separate tab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants