Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query strings not properly decoded #683

Open
andrew-stevenson-sociomantic opened this issue Mar 1, 2019 · 0 comments
Open

Query strings not properly decoded #683

andrew-stevenson-sociomantic opened this issue Mar 1, 2019 · 0 comments
Labels
type-bug

Comments

@andrew-stevenson-sociomantic
Copy link
Contributor

andrew-stevenson-sociomantic commented Mar 1, 2019 •
edited
Loading

Uri.parse does not properly unescape query strings. e.g. my+Browser%2B gives my+Browser+ and it should be my Browser+.

There is a tentative fix in https://github.com/andrew-stevenson-sociomantic/ocean/commits/url_parsing (last 2 commits). I no longer use the code however and don't currently have the time to fully verify it or check the performance.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mihails-strasuns @andrew-stevenson-sociomantic