Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add counter and logging of protocol errors #30

Open
gavin-norman-sociomantic opened this issue Jun 7, 2017 · 3 comments
Open

Add counter and logging of protocol errors #30

gavin-norman-sociomantic opened this issue Jun 7, 2017 · 3 comments

Comments

@gavin-norman-sociomantic

A protocol error that occurs while handling a request represents a serious error. These should not go unnoticed. If we write them to the stats log, then we can set up alerting in the live system to notify maintainers.

@gavin-norman-sociomantic
Copy link
Author

The ProtocolError exception is used for several different things in different modules, for example:

  1. Connection-level (e.g. establishment / authentication) errors.
  2. Message-level errors.
  3. Request-level protocol errors, in request handlers.

Each type of error could be counted separately, as they represent different things, really.

@gavin-norman-sociomantic
Copy link
Author

gavin-norman-sociomantic commented Oct 18, 2017

In addition to the different types of protocol error mentioned above, it'd also be nice to catch and log arbitrary errors from other sources (e.g. verify calls throwing).

@gavin-norman-sociomantic
Copy link
Author

gavin-norman-sociomantic commented Dec 20, 2018

Logging of auth errors added in #379. (I'm not 100% sure that covers auth protocol errors, though.)

@gavin-norman-sociomantic gavin-norman-sociomantic modified the milestones: v5.4.0, v5.5.0 Dec 20, 2018
@Geod24 Geod24 removed this from the v5.5.0 milestone Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants