Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl-C does not work on Windows #1382

Open
dgw opened this issue Sep 21, 2018 · 3 comments
Open

Ctrl-C does not work on Windows #1382

dgw opened this issue Sep 21, 2018 · 3 comments
Labels
Bug Things to squish; generally used for issues Low Priority Windows

Comments

@dgw
Copy link
Member

dgw commented Sep 21, 2018

As touched on in my approval of #1381, Windows doesn't support SIGUSR1. Sopel's signal handler unsafely handles all signal types in one if ... or ... line, and crashes with an AttributeError on Ctrl-C because of the reference to a missing signal type.

What's fun is that Sopel's threading prevents the exception from terminating the whole program anyway. So, Ctrl-C is pretty well broken on Windows (at least on Win7, the only version I have available).

I'm putting this in the 6.6.0 milestone just for visibility, but it can just be punted to the next release if not fixed in time. It's been around for at least 5 years already, and not many Sopel users (anecdotally) run Windows. (I'm not fixing it immediately myself because, well… Windows. Meh. 😹)

@dgw dgw added Bug Things to squish; generally used for issues Low Priority Windows labels Sep 21, 2018
@dgw dgw added this to the 6.6.0 milestone Sep 21, 2018
@dgw dgw modified the milestones: 6.6.0, 7.0.0 Dec 26, 2018
@dgw dgw modified the milestones: 7.0.0, 7.1.0 Nov 16, 2019
@dgw
Copy link
Member Author

dgw commented Nov 16, 2019

We'll worry about this later. At present I can't even get Python installed on my Windows machine to check if this is even still a problem. Someone else feel free to test, but any fix that might be needed for this is officially punted to 7.1 no matter what.

@dgw dgw modified the milestones: 7.1.0, 8.0.0 May 8, 2020
@dgw
Copy link
Member Author

dgw commented May 8, 2020

Let's not look into this until we drop old Python releases for Sopel 8. This might be fixed in currently-supported versions on Windows, or at least might be easier to debug with a smaller target range.

@dgw
Copy link
Member Author

dgw commented Jul 14, 2022

We still don't have much motivation to worry about this, given the existence of WSL. Dropping to wishlist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Things to squish; generally used for issues Low Priority Windows
Projects
None yet
Development

No branches or pull requests

1 participant