Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type conflict between base tools.jobs.Scheduler class and plugins.jobs.Scheduler subclass #2476

Open
dgw opened this issue Jun 15, 2023 · 0 comments
Labels
Housekeeping Code cleanup, removal of deprecated stuff, etc. Needs Triage Issues that need to be reviewed and categorized

Comments

@dgw
Copy link
Member

dgw commented Jun 15, 2023

Raised in #2471. Band-aided with a type: ignore[assignment] comment, but we should really redesign this part of the API.

@Exirel pointed out that Sopel doesn't really need a non-plugin job scheduler any more, since it can just use the asyncio event loop now. Since tools.jobs is already documented as internal tools that plugin developers shouldn't use, any reason we shouldn't just drop the tools.jobs module and move the still-useful parts into plugins.jobs?

(tools.jobs says "As of Sopel 5.3, this is an internal tool […]", so that's several years of warning that plugin authors shouldn't use it. The Scheduler class also used to be a JobScheduler before some refactoring years ago, so code that tries to use the even older version that wasn't explicitly documented as being internal will fail.)

@dgw dgw added Housekeeping Code cleanup, removal of deprecated stuff, etc. Needs Triage Issues that need to be reviewed and categorized labels Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Housekeeping Code cleanup, removal of deprecated stuff, etc. Needs Triage Issues that need to be reviewed and categorized
Projects
None yet
Development

No branches or pull requests

1 participant