Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save joined channels in the configuration #563

Closed
phantium opened this issue Jul 7, 2014 · 5 comments
Closed

Save joined channels in the configuration #563

phantium opened this issue Jul 7, 2014 · 5 comments
Assignees
Labels
Milestone

Comments

@phantium
Copy link
Contributor

phantium commented Jul 7, 2014

Right now when you add a channel with !join it does not save the channel to the config and the channel is not rejoined after restarting the bot.

Personally I would like to see this added, however also with the option for a delay joining channels so that bots who join a lot of channels don't flood the server.

Chances are, that I'll write a module to do this as it's something I need personally.
However in my case it would not make sense to write this into the default.cfg, as more than 10 channels would already be too difficult to maintain in the config file.

@tyrope tyrope added the Feature label Jul 7, 2014
@Nuvelle
Copy link

Nuvelle commented Jul 11, 2014

I would have use for this too!

At the moment I put the channels into a variable and pickle the variable.

Then on startup unpickle and join the channels.

@Exirel
Copy link
Contributor

Exirel commented Feb 26, 2019

It is doable, for sure, but I don't know what the proper interface would be. In particular, I wonder what the default behavior should be.

For example, would it be something like this?

<me> !join [channel] [remember: default=no]

This would make Sopel join the channel until restart:

<me> !join #onlyonce

This would make Sopel save the channel in its configuration:

<me> !join #awesome yes

But maybe there are better way to tell that. What do you think @dgw? Is that something to consider?

@dgw
Copy link
Member

dgw commented Feb 26, 2019

I'd say it should always save joined (and parted) channels to the config. The optional second argument to .join is already used for channel key/password, and it would get complicated to add a third argument that's also optional.

@Exirel
Copy link
Contributor

Exirel commented Feb 26, 2019

Oh right! It makes sense. I can do that this week.

7.x or 6.x?

@dgw
Copy link
Member

dgw commented Feb 27, 2019

7.x, probably. Especially if you feel like implementing general config auto-save (#1354) at the same time. 😁

@Exirel Exirel added this to the 7.0.0 milestone Mar 21, 2019
@Exirel Exirel self-assigned this Mar 21, 2019
@dgw dgw closed this as completed in #1492 Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants