Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

remove todo!s in typecheck_call_helper #62

Closed
yaahc opened this issue Apr 25, 2024 · 1 comment
Closed

remove todo!s in typecheck_call_helper #62

yaahc opened this issue Apr 25, 2024 · 1 comment

Comments

@yaahc
Copy link
Collaborator

yaahc commented Apr 25, 2024

we currently have some unimplemented branches for subtyping in function calls with named parameters.

  • Add tests for this case
  • trigger the panic from the todo!()
  • replace panics with the proper logic

The current implementation produces an error before codegen, so there will proably be additional changes needed to the typechecker as part of this change.

@yaahc
Copy link
Collaborator Author

yaahc commented Apr 25, 2024

fixed by #63

@yaahc yaahc closed this as completed Apr 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant