Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix_latencies is running every restart by each app server, affecting Redis performance #284

Closed
hopfish opened this issue Nov 21, 2019 · 4 comments

Comments

@hopfish
Copy link

hopfish commented Nov 21, 2019

Hello!

We have a Split setup using the Ruby client in consumer mode, with Redis to communicate with the split synchronizer. The fix_latencies fix found here has the effect of consuming a ton of Redis resources. This is run on each restart of the servers, and on each app server where we use the split gem. With a large number of app servers, and a shared Redis instance, the repeated scan commands are causing Redis performance issues.

Could we have an option to disable the fix? It has already been run, and doesn't need to be re-run each restart.

Thanks!

@NicoZelaya
Copy link
Contributor

Hi @hopfish !

Our sincere apologies for the issues this might have caused. We'll look into it and I'll get back to you with our plan, but definitely makes sense to not run it several times.

Thank you very much for reporting this!

I'll keep you posted,
Nico.

@NicoZelaya
Copy link
Contributor

Hello again @hopfish ! We're already working on a fix for this issue. First time it runs we'll mark it as such and afterwards it won't run again.

Looking at sending it for testing to our staging environment soon, if all goes well it should be released as stable this week.

I'll keep updating you here.

Thanks for your patience!
Nico.

Nico.

@sanzmauro
Copy link
Contributor

Hi @hopfish !

We released 7.0.2 with the fix. Again our sincere apologies for the issues and please let us know if you have any concerns after upgrading the sdk.

Kindest regards,
Mauro.

@hopfish
Copy link
Author

hopfish commented Nov 25, 2019

Great, thanks for the speedy response! We will upgrade and let you know if there are any more issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants