Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppDeploymentRequest should support multiple resources #105

Open
waseemh opened this issue Aug 22, 2016 · 3 comments
Open

AppDeploymentRequest should support multiple resources #105

waseemh opened this issue Aug 22, 2016 · 3 comments

Comments

@waseemh
Copy link

waseemh commented Aug 22, 2016

SPI assumes that an app deployment has a single resource. This is enforced in AppDeploymentRequest which allows a single Resource object.
However in real-world use cases it might not be always correct.

For example: when deploying a web application with UI and backend, each component runs on a separate container from different Docker images -> multiple DockerResources for same deployment request.

Another realistic example comes from Kubernetes world - A Pod is a single unit of deployment which might include multiple containers of different images. Such scenario is impossible to implement using current SPI and spring-cloud-deployer-kubernetes module:
http://kubernetes.io/docs/user-guide/pods/multi-container/#sample-file

To solve this issue, AppDeploymentRequest should include a list of Resource objects, rather than a single object.

@markfisher
Copy link
Contributor

Would you consider this covered by #99 ?

@waseemh
Copy link
Author

waseemh commented Aug 23, 2016

It depends whether application grouping takes into consideration mutiple resources or not. For example it should allow mapping each application to its resource.
Also apps in group should be in same deployment context to be considered as a 'single unit of deployment'

@waseemh
Copy link
Author

waseemh commented Aug 23, 2016

Want to mention also that different resources might require different deployment properties in same app deployment context (i.e: app is composed of nginx and apache containers - nginx DockerResource requires 1025Mi while Apache DockerResource requires 512Mi)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants