Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increment counter only on success in ItemReaders (mainly Paging*ItemReaders). [BATCH-1716] #1869

Open
spring-projects-issues opened this issue Mar 20, 2011 · 1 comment
Open

Increment counter only on success in ItemReaders (mainly Paging*ItemReaders). [BATCH-1716] #1869

spring-projects-issues opened this issue Mar 20, 2011 · 1 comment
Labels
in: infrastructure status: waiting-for-triage Issues that we did not analyse yet type: enhancement

Comments

@spring-projects-issues
Copy link
Collaborator

Dave Syer opened BATCH-1716 and commented

Affects: 2.1.0
@spring-projects-issues
Copy link
Collaborator Author

Dave Syer commented

It's not really obvious that we should change this. A reader can throw an exception and still have moved forward in the underlying resource (e.g. ResultSet). If we do address this request, then it would mean something quite complicated, like a list of exceptions that prevent the counter from incrementing. Postponing while we think about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in: infrastructure status: waiting-for-triage Issues that we did not analyse yet type: enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@spring-projects-issues