Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: squat/postpone
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0.5.0
Choose a base ref
...
head repository: squat/postpone
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
  • 14 commits
  • 7 files changed
  • 2 contributors

Commits on Mar 14, 2014

  1. Add _slice method to abstract array conversion

    This commit adds a private `_slice` method to the Postpone class to
    convert iterable objects into arrays. This method performs the conversion
    by trying to call `Array.prototype.slice` on the provided object and then
    defaulting to a manual iteration if the first method fails.
    squat committed Mar 14, 2014
    Configuration menu
    Copy the full SHA
    8cd76d4 View commit details
    Browse the repository at this point in the history
  2. Continue adding support for IE8

    This commit abstracts some methods inside of Postpone so that the
    execution of the methods is agnostic to their implementation and they
    can be implemented to support non-standards-compliant browsers.
    squat committed Mar 14, 2014
    Configuration menu
    Copy the full SHA
    e761a07 View commit details
    Browse the repository at this point in the history
  3. Correct IE8 event name.

    squat committed Mar 14, 2014
    Configuration menu
    Copy the full SHA
    e86f68c View commit details
    Browse the repository at this point in the history
  4. Finish IE8 enhancements.

    squat committed Mar 14, 2014
    Configuration menu
    Copy the full SHA
    5130704 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2014

  1. Added support for <object>

    Pablo Ziliani committed Mar 20, 2014
    Configuration menu
    Copy the full SHA
    56d8ef2 View commit details
    Browse the repository at this point in the history
  2. Fix comment style

    Pablo Ziliani committed Mar 20, 2014
    Configuration menu
    Copy the full SHA
    d314ece View commit details
    Browse the repository at this point in the history
  3. Merge pull request #4 from pabloz-globant/master

    Added support for <object>
    squat committed Mar 20, 2014
    Configuration menu
    Copy the full SHA
    d2093af View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2014

  1. Configuration menu
    Copy the full SHA
    2cd616b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    96a3969 View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2014

  1. Softer method to make Safari refresh the object content

    Pablo Ziliani committed Apr 1, 2014
    Configuration menu
    Copy the full SHA
    3079e96 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2014

  1. Account for case where all elements are rerendered

    This commit accounts for an edge case where Postpone would not
    correctly load elemnts when they had scrolled into view. Specifically,
    it takes care of the case when a set of already postponed elements are
    completely re-rendered by an application. Re-rendering a page with the
    same content may result in completely equivalent markup to the markup
    that existed before, but from a browser's point of view, the DOM nodes
    represented by those sets of markup are not identical. Postpone was
    treating these nodes as identical, so if your Backbone app re-rendered a
    bunch of still un-loaded images, Postpone would be unable to load them.
    squat committed Apr 26, 2014
    Configuration menu
    Copy the full SHA
    684883f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7dade5e View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2014

  1. Optimize getElements() method

    This commit optimizes the internal `getElements` method, which Postpone
    uses to locate and register all elements on the page who's resources
    should be managed. This code change takes advantage of the fact that if
    an element is already being managed by Postpone and the postponed
    elements on the page have not changed, then the index of that given
    element in the array of postponed elements should already be known. This
    allows for the elimination of the `Array.prototype.indexOf` method,
    effectively changing the line of code from O(n) to O(1).
    squat committed Apr 28, 2014
    Configuration menu
    Copy the full SHA
    c9d20db View commit details
    Browse the repository at this point in the history

Commits on May 28, 2014

  1. Correct bug where start did not bind events

    This commit corrects an issue where the `start` method was not rebinding
    events after these event listeners after these events were removed using
    `stop`.
    squat committed May 28, 2014
    Configuration menu
    Copy the full SHA
    6e54434 View commit details
    Browse the repository at this point in the history
Loading