Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There are several inconsistencies between the math-formula and py-code #1

Open
roveretoa opened this issue Nov 3, 2022 · 4 comments

Comments

@roveretoa
Copy link

roveretoa commented Nov 3, 2022

There are several inconsistencies between the math-formula and py-code:

(1) Problem 9: Index
In the py-code the index is added by 10, but the right side of the equation shows something else.

(2) Problem 9: Cumsum
The dx lambda parameters should be i, o ?

(3) There are two 'Problem 9'

(4) Problem 19: Matmul
In the py-code the summation is divided by M, but the math-formula is not.

(5) Problem 20: 2D Conv
In the py-code the summation is divided by (kh * kw), but the math-formula is not.

@kshitijsachan
Copy link

Also problem 6:
Description reads: $$𝑓(𝑥0)=[𝑥0×0/𝐼,𝑥0×2/𝐼,𝑥0×3/𝐼,…,𝑥0×(𝐼−1)/𝐼]$$

Missing the $$𝑥0×1/𝐼$$ term.

@srush
Copy link
Owner

srush commented Oct 8, 2023

Thanks. I'll fix these up.

@ricardoV94
Copy link

Shouldn't index j start at 0 in the 1-D convolution formula?

@nilsreck
Copy link

There are several inconsistencies between the math-formula and py-code:

(1) Problem 9: Index In the py-code the index is added by 10, but the right side of the equation shows something else.

(2) Problem 9: Cumsum The dx lambda parameters should be i, o ?

(3) There are two 'Problem 9'

(4) Problem 19: Matmul In the py-code the summation is divided by M, but the math-formula is not.

(5) Problem 20: 2D Conv In the py-code the summation is divided by (kh * kw), but the math-formula is not.

In Problem 20, the formula in the py-code is still divided by (kh * kw)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants