You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is generally a pattern we want to avoid, as in most cases, if there's any action to be performed, status-go should take care of that before passing it to the client.
Another issue is that it might create cycles, as this is called in response to RPC, but makes RPC calls, in this case it's handled by checking whether spectated/spectating is set, but it's fragile.
To start with, I think we should focus on removing spectating from a reaction to a status-go signal.
We should spectate a community only when we open a page of a community, not in response to any not-joined community in status-go.
Secondly, we should remove all the permisions checks. We should make those only when a user opens a community page.
And maybe we can discuss how to keep that page up to date, whether periodically, or by only checking permissions for that community that the user is on.
The text was updated successfully, but these errors were encountered:
Description
status-mobile/src/status_im/contexts/communities/events.cljs
Line 34 in 58e9ae0
This code is run every time status-go signals the client of a community.
You can see that it will ask back status-go for extra information:
This is generally a pattern we want to avoid, as in most cases, if there's any action to be performed, status-go should take care of that before passing it to the client.
Another issue is that it might create cycles, as this is called in response to RPC, but makes RPC calls, in this case it's handled by checking whether
spectated
/spectating
is set, but it's fragile.To start with, I think we should focus on removing
spectating
from a reaction to a status-go signal.We should spectate a community only when we open a page of a community, not in response to any not-joined community in status-go.
Secondly, we should remove all the permisions checks. We should make those only when a user opens a community page.
And maybe we can discuss how to keep that page up to date, whether periodically, or by only checking permissions for that community that the user is on.
The text was updated successfully, but these errors were encountered: