[all] Change from greek prefixes to ASCII (lit#1959)

* Revert private prefixes from greek to ascii

* Fix imported symbols

* Additional renames.

* Add `_` to all prefixes

* Update changesets metadata

Author: kevinpschaaf

.changeset/fifty-trainers-check.md

@@ -0,0 +1,7 @@
+---
+'lit-html': major
+---
+
+Changed all prefixes used for minifying object and class properties from greek
+characters to ASCII, to avoid requiring an explicit script charset on some
+browser/webview environments.

packages/labs/ssr/src/lib/lit-element-renderer.ts

@@ -6,12 +6,12 @@
 
 import {ElementRenderer} from './element-renderer.js';
 import {LitElement, CSSResult, ReactiveElement} from 'lit';
-import {_Φ} from 'lit-element/private-ssr-support.js';
+import {_$LE} from 'lit-element/private-ssr-support.js';
 import {render, RenderInfo} from './render-lit-html.js';
 
 export type Constructor<T> = {new (): T};
 
-const {attributeToProperty, changedProperties} = _Φ;
+const {attributeToProperty, changedProperties} = _$LE;
 
 /**
  * ElementRenderer implementation for LitElements

packages/labs/ssr/src/lib/render-lit-html.ts

@@ -16,7 +16,7 @@ import type {
 import {nothing, noChange} from 'lit';
 import {PartType} from 'lit/directive.js';
 import {isTemplateResult} from 'lit/directive-helpers.js';
-import {_Σ} from 'lit-html/private-ssr-support.js';
+import {_$LH} from 'lit-html/private-ssr-support.js';
 
 const {
   getTemplateHtml,
@@ -30,7 +30,7 @@ const {
   PropertyPart,
   BooleanAttributePart,
   EventPart,
-} = _Σ;
+} = _$LH;
 
 import {digestForTemplateResult} from 'lit/experimental-hydrate.js';
 

packages/lit-element/src/lit-element.ts

@@ -207,7 +207,7 @@ if (DEV_MODE) {
  *
  * We currently do not make a mangled rollup build of the lit-ssr code. In order
  * to keep a number of (otherwise private) top-level exports  mangled in the
- * client side code, we export a _Φ object containing those members (or
+ * client side code, we export a _$LE object containing those members (or
  * helper methods for accessing private fields of those members), and then
  * re-export them for use in lit-ssr. This keeps lit-ssr agnostic to whether the
  * client-side code is being used in `dev` mode or `prod` mode.
@@ -217,7 +217,7 @@ if (DEV_MODE) {
  *
  * @private
  */
-export const _Φ = {
+export const _$LE = {
   _$attributeToProperty: (
     el: LitElement,
     name: string,

packages/lit-element/src/private-ssr-support.ts

@@ -4,21 +4,21 @@
  * SPDX-License-Identifier: BSD-3-Clause
  */
 
-import {_Φ as p} from './lit-element.js';
+import {_$LE as p} from './lit-element.js';
 
 /**
  * END USERS SHOULD NOT RELY ON THIS OBJECT.
  *
  * We currently do not make a mangled rollup build of the lit-ssr code. In order
  * to keep a number of (otherwise private) top-level exports  mangled in the
- * client side code, we export a _Φ object containing those members (or
+ * client side code, we export a _$LE object containing those members (or
  * helper methods for accessing private fields of those members), and then
  * re-export them for use in lit-ssr. This keeps lit-ssr agnostic to whether the
  * client-side code is being used in `dev` mode or `prod` mode.
  *
  * @private
  */
-export const _Φ = {
+export const _$LE = {
   attributeToProperty: p._$attributeToProperty,
   changedProperties: p._$changedProperties,
 };

packages/lit-html/src/directive-helpers.ts

@@ -4,7 +4,7 @@
  * SPDX-License-Identifier: BSD-3-Clause
  */
 
-import {_Σ, Part, DirectiveParent, TemplateResult} from './lit-html.js';
+import {_$LH, Part, DirectiveParent, TemplateResult} from './lit-html.js';
 import {
   DirectiveResult,
   DirectiveClass,
@@ -13,7 +13,7 @@ import {
 } from './directive.js';
 type Primitive = null | undefined | boolean | number | string | symbol | bigint;
 
-const {_ChildPart: ChildPart} = _Σ;
+const {_ChildPart: ChildPart} = _$LH;
 
 type ChildPart = InstanceType<typeof ChildPart>;
 

packages/lit-html/src/experimental-hydrate.ts

@@ -6,7 +6,7 @@
 
 import type {TemplateResult} from './lit-html.js';
 
-import {noChange, RenderOptions, _Σ} from './lit-html.js';
+import {noChange, RenderOptions, _$LH} from './lit-html.js';
 import {AttributePartInfo, PartType} from './directive.js';
 import {
   isPrimitive,
@@ -20,7 +20,7 @@ const {
   _resolveDirective: resolveDirective,
   _ChildPart: ChildPart,
   _ElementPart: ElementPart,
-} = _Σ;
+} = _$LH;
 
 type ChildPart = InstanceType<typeof ChildPart>;
 type TemplateInstance = InstanceType<typeof TemplateInstance>;

packages/lit-html/src/lit-html.ts

@@ -1519,7 +1519,7 @@ class ElementPart {
  *
  * We currently do not make a mangled rollup build of the lit-ssr code. In order
  * to keep a number of (otherwise private) top-level exports  mangled in the
- * client side code, we export a _Σ object containing those members (or
+ * client side code, we export a _$LH object containing those members (or
  * helper methods for accessing private fields of those members), and then
  * re-export them for use in lit-ssr. This keeps lit-ssr agnostic to whether the
  * client-side code is being used in `dev` mode or `prod` mode.
@@ -1529,7 +1529,7 @@ class ElementPart {
  *
  * @private
  */
-export const _Σ = {
+export const _$LH = {
   // Used in lit-ssr
   _boundAttributeSuffix: boundAttributeSuffix,
   _marker: marker,

packages/lit-html/src/private-ssr-support.ts

@@ -5,21 +5,21 @@
  */
 
 import {Directive, PartInfo} from './directive.js';
-import {_Σ as p, AttributePart, noChange, Part} from './lit-html.js';
+import {_$LH as p, AttributePart, noChange, Part} from './lit-html.js';
 export type {Template} from './lit-html.js';
 
 /**
  * END USERS SHOULD NOT RELY ON THIS OBJECT.
  *
  * We currently do not make a mangled rollup build of the lit-ssr code. In order
  * to keep a number of (otherwise private) top-level exports mangled in the
- * client side code, we export a _Σ object containing those members (or
+ * client side code, we export a _$LH object containing those members (or
  * helper methods for accessing private fields of those members), and then
  * re-export them for use in lit-ssr. This keeps lit-ssr agnostic to whether the
  * client-side code is being used in `dev` mode or `prod` mode.
  * @private
  */
-export const _Σ = {
+export const _$LH = {
   boundAttributeSuffix: p._boundAttributeSuffix,
   marker: p._marker,
   markerMatch: p._markerMatch,

packages/lit-html/src/test/lit-html_test.ts

@@ -32,8 +32,8 @@ import {AsyncDirective} from '../async-directive.js';
 import {createRef, ref} from '../directives/ref.js';
 
 // For compiled template tests
-import {_Σ} from '../private-ssr-support.js';
-const {AttributePart} = _Σ;
+import {_$LH} from '../private-ssr-support.js';
+const {AttributePart} = _$LH;
 
 type AttributePart = InstanceType<typeof AttributePart>;
 

rollup-common.js

@@ -17,17 +17,17 @@ import virtual from '@rollup/plugin-virtual';
 // defined here rather than via an argument to litProdConfig() so we can
 // validate the list used by each package is unique (since copy/pasting the
 // individual package-based configs is common and error-prone)
-const STABLE_PROPERTY_PREFIX = 'Ξ';
+const STABLE_PROPERTY_PREFIX = '_$A';
 const PACKAGE_CLASS_PREFIXES = {
-  lit: 'ϖ',
-  'lit-html': 'Σ',
-  'lit-element': 'Φ',
-  '@lit/reactive-element': 'Π',
-  '@lit-labs/motion': 'δ',
-  '@lit-labs/react': 'Ω',
-  '@lit-labs/scoped-registry-mixin': 'Ϋ',
-  '@lit-labs/ssr-client': 'Λ',
-  '@lit-labs/task': '⍶',
+  lit: '_$B',
+  'lit-html': '_$C',
+  'lit-element': '_$D',
+  '@lit/reactive-element': '_$E',
+  '@lit-labs/motion': '_$F',
+  '@lit-labs/react': '_$G',
+  '@lit-labs/scoped-registry-mixin': '_$H',
+  '@lit-labs/ssr-client': '_$I',
+  '@lit-labs/task': '_$J',
 };
 
 // Validate prefix uniqueness