Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: SSH Option Validation TODO #34

Open
5 tasks
raamsri opened this issue Jan 5, 2025 · 0 comments
Open
5 tasks

feature: SSH Option Validation TODO #34

raamsri opened this issue Jan 5, 2025 · 0 comments
Labels
Essential It is understood that this can't be overlooked, and demands attention. good first issue Good for newcomers Needs Decision The issue is understood, but the best solution is undecided. Wait for a decision before writing cod Needs More Info The issue is acknowledged, but requires more information for an objective understanding

Comments

@raamsri
Copy link
Contributor

raamsri commented Jan 5, 2025

Feature Request

Summary

Enhance SSH option validation for remote ZFS operations

Motivation

Current SSH option validation needs improvement for security and reliability

Detailed Design

  1. Validation Rules:

    • Whitelist allowed SSH options
    • Validate option format
    • Check for security implications
    • Handle custom configurations

  2. Implementation Details:

    • Option parser
    • Security checks
    • Configuration validation
    • Error handling

Acceptance Criteria

  • Validate all SSH options
  • Prevent command injection
  • Handle custom configurations
  • Proper error messages
  • Security documentation

Additional Context

Located in pkg/zfs/dataset/data_transfer.go
@raamsri raamsri added good first issue Good for newcomers Needs Decision The issue is understood, but the best solution is undecided. Wait for a decision before writing cod Essential It is understood that this can't be overlooked, and demands attention. Needs More Info The issue is acknowledged, but requires more information for an objective understanding labels Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Essential It is understood that this can't be overlooked, and demands attention. good first issue Good for newcomers Needs Decision The issue is understood, but the best solution is undecided. Wait for a decision before writing cod Needs More Info The issue is acknowledged, but requires more information for an objective understanding
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@raamsri