Submit event

[carstenjaksch]

The form is missing the default submit event. I am about to do a PR, but was told to discuss this first.

I would do it in the successHook:

successHook(response) {
    {{ success_hook }}

    this.$refs.form.dispatchEvent(new Event('submit', {
        bubbles: true,
        cancelable: true
    }));

    setTimeout(() => {
        this.success = false
    }, 10000)
},

Don't know which is better: Before or after {{ success_hook }}.

[robdekort]

Thanks for discussing it first. What default submit event do you mean?

[carstenjaksch]

Yes, I know that. But I think the form is more developer-friendly if it dispatches the default event. I expected it to do so.

Using the success_hook for such a basic thing seems not right to me. It is just easier to have the all-known submit event there, ready to use like you normally would with a HTML form.

[robdekort]

Thing is we prevent the actual form submission from happening (using: @click.prevent="submit"), therefore I don't think it should fire. This way we also follow the default Laravel Precognition + Alpine docs.

[carstenjaksch]

Then maybe a custom event? Most form plugins/libraries that handle the submit via JS at least dispatch a custom event after submit.

[robdekort]

I don’t see the need for now. Sorry. But you can always publish the form handler and add it for your own projects.

[carstenjaksch]

Thanks, will do that.