Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execute configure script before running make on p2p #228

Open
crioto opened this issue Jan 23, 2018 · 5 comments
Open

Execute configure script before running make on p2p #228

crioto opened this issue Jan 23, 2018 · 5 comments

Comments

@crioto
Copy link
Member

crioto commented Jan 23, 2018

Before building p2p we need to configure it. For this reason configure shell script needs to be executed, which generates config.make file used by Makefile.
configure accepts two parameters:

  • --branch=<branch_name>. This parameter can be omit - in this case configure script will try to determine branch manually by executing git rev-parse --abbrev-ref HEAD. Also note, that for release (production) build we need to pass HEAD as a value for this parameter.
  • --dht=<dht_endpoint>. This will set default DHT endpoint. Possible values are: mdht.subut.ai:6881 for production, 54.93.172.70:6881 for master and 18.195.169.215:6881 for anything else including dev branch.
@lbthomsen
Copy link
Contributor

Well yes :) I am not sure what the issue is though?

@crioto
Copy link
Member Author

crioto commented Jan 23, 2018

It's an enhancement for snapcraft.

@lbthomsen
Copy link
Contributor

Well - if you switch the plugin to "autotools" it will run ./configure ; make ; make install so that ought to work. You can also specify customized ./configure parameters (see btrfs in the snapcraft.yaml.template)

@crioto
Copy link
Member Author

crioto commented Jan 24, 2018

So basically to make this work I need to modify this snapcraft.yaml.template? And what about docker image for tests? It is possible to use it?

@lbthomsen
Copy link
Contributor

Yeah I just tested that - it should work as described at: https://github.com/lbthomsen/docker-snapcraft

If you're using Ubuntu just install snapcraft - that's better (certainly faster) but on an unsupported system the docker-snapcraft should work.

Simply - in your "snap" checkout run ./configure and then snapcraft (using script that call docker).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants