-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Execute configure script before running make on p2p #228
Comments
Well yes :) I am not sure what the issue is though? |
It's an enhancement for snapcraft. |
Well - if you switch the plugin to "autotools" it will run ./configure ; make ; make install so that ought to work. You can also specify customized ./configure parameters (see btrfs in the snapcraft.yaml.template) |
So basically to make this work I need to modify this snapcraft.yaml.template? And what about docker image for tests? It is possible to use it? |
Yeah I just tested that - it should work as described at: https://github.com/lbthomsen/docker-snapcraft If you're using Ubuntu just install snapcraft - that's better (certainly faster) but on an unsupported system the docker-snapcraft should work. Simply - in your "snap" checkout run |
Before building p2p we need to configure it. For this reason
configure
shell script needs to be executed, which generatesconfig.make
file used by Makefile.configure
accepts two parameters:--branch=<branch_name>
. This parameter can be omit - in this case configure script will try to determine branch manually by executinggit rev-parse --abbrev-ref HEAD
. Also note, that for release (production) build we need to passHEAD
as a value for this parameter.--dht=<dht_endpoint>
. This will set default DHT endpoint. Possible values are:mdht.subut.ai:6881
for production,54.93.172.70:6881
for master and18.195.169.215:6881
for anything else including dev branch.The text was updated successfully, but these errors were encountered: